From: Paul Mackerras <paulus@samba.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org
Subject: Re: [GITK PATCH v2] Add menu accelerators
Date: Tue, 21 Oct 2008 10:21:58 +1100 [thread overview]
Message-ID: <18685.4758.877209.908423@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <200810200000.33035.robin.rosenberg@dewire.com>
Robin Rosenberg writes:
> Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
> ---
> gitk | 80 +++++++++++++++++++++++++++++++++---------------------------------
> 1 files changed, 40 insertions(+), 40 deletions(-)
>
> This one is slightly better than the first one. Works with gitk id...id too.
With that patch, I'm finding that pressing Alt-f pops up the File
menu, but also triggers the binding for 'f' in the main window (scroll
diff window to the next file), which is annoying. I'm not sure why, I
will need to track that down.
Paul.
prev parent reply other threads:[~2008-10-20 23:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 6:09 [Gitk Patch 0/6] Robin Rosenberg
2008-10-09 6:09 ` [Gitk PATCH 1/6] gitk: Add procedure to create accelerated menus Robin Rosenberg
2008-10-09 6:09 ` [Gitk PATCH 2/6] gitk: Change menus to use accelerated design Robin Rosenberg
2008-10-09 6:09 ` [Gitk PATCH 3/6] gitk: regenerated po files Robin Rosenberg
2008-10-09 6:09 ` [Gitk PATCH 4/6] gitk: Add accelerator hints Robin Rosenberg
2008-10-09 6:09 ` [Gitk PATCH 5/6] gitk: regenerated po files Robin Rosenberg
2008-10-09 6:09 ` [Gitk PATCH 6/6] gitk: Add menu accelerators for Swedish translation Robin Rosenberg
2008-10-11 1:40 ` [Gitk PATCH 1/6] gitk: Add procedure to create accelerated menus Paul Mackerras
2008-10-11 11:39 ` Robin Rosenberg
2008-10-11 2:44 ` [Gitk Patch 0/6] Paul Mackerras
2008-10-11 11:14 ` Robin Rosenberg
2008-10-18 12:11 ` Paul Mackerras
2008-10-19 21:19 ` [GITK PATCH] Add menu accelerators Robin Rosenberg
2008-10-19 22:00 ` [GITK PATCH v2] " Robin Rosenberg
2008-10-20 23:21 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18685.4758.877209.908423@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).