git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: "Alexander Gavrilov" <angavrilov@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH (GITK)] gitk: Fix commit encoding support.
Date: Thu, 13 Nov 2008 22:42:58 +1100	[thread overview]
Message-ID: <18716.4802.663635.847263@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <bb6f213e0811100406l2fcde5b8k8772360947b948fd@mail.gmail.com>

Alexander Gavrilov writes:

> If all commits were loaded through cat-file, that would be the way to
> go. Otherwise, when one code path uses one method of conversion, and
> another one, which is used rarely and semi-randomly, a different
> method, it may lead to confusing results if something goes slightly
> wrong.

OK, that makes sense.  I applied the patch with a paragraph added to
the description that explains that.

Thanks,
Paul.

      reply	other threads:[~2008-11-13 11:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-09 15:06 [PATCH (GITK)] gitk: Fix commit encoding support Alexander Gavrilov
2008-11-10 11:46 ` Paul Mackerras
2008-11-10 12:06   ` Alexander Gavrilov
2008-11-13 11:42     ` Paul Mackerras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18716.4802.663635.847263@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=angavrilov@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).