From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: Moumita <dhar61595@gmail.com>, git@vger.kernel.org
Cc: "Calvin Wan" <calvinwan@google.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Patrick Steinhardt" <ps@pks.im>,
"Elijah Newren" <newren@gmail.com>
Subject: Re: [PATCH 1/1] refs.c: fix -Wsign-compare warnings
Date: Sat, 08 Feb 2025 20:01:51 +0100 [thread overview]
Message-ID: <190f7624-d45e-4c5f-a29a-b3be84e113d1@app.fastmail.com> (raw)
In-Reply-To: <20250208182736.18133-2-dhar61595@gmail.com>
On Sat, Feb 8, 2025, at 19:27, Moumita wrote:
> Remove DISABLE_SIGN_COMPARE_WARNINGS from refs.c and fix integer
> comparison issues that caused -Wsign-compare warnings.
>
> Tested using `make DEVELOPER=1` and `make t` to ensure correctness.
Notes on how the patch/commit was tested is usually not
included in the commit message.
> ---
You forgot the signoff.
next prev parent reply other threads:[~2025-02-08 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-08 18:27 [PATCH 0/1] [GSoC] [Newbie] Fix -Wsign-compare warnings in refs.c Moumita
2025-02-08 18:27 ` [PATCH 1/1] refs.c: fix -Wsign-compare warnings Moumita
2025-02-08 19:01 ` Kristoffer Haugsbakk [this message]
2025-02-08 22:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=190f7624-d45e-4c5f-a29a-b3be84e113d1@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail.com \
--cc=calvinwan@google.com \
--cc=dhar61595@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).