From: Paul Mackerras <paulus@samba.org>
To: Bernt Hansen <bernt@norang.ca>
Cc: Pat Thoyts <patthoyts@users.sourceforge.net>, git@vger.kernel.org
Subject: Re: [PATCH] Skip translation of wrong Tcl version text
Date: Tue, 3 Nov 2009 22:31:21 +1100 [thread overview]
Message-ID: <19184.5257.944412.835848@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <87ljipje03.fsf@gollum.intra.norang.ca>
Bernt Hansen writes:
> We check the required Tcl version number before we setup msgcat for
> language translation. If the Tcl version is too old just display the
> untranslated error text.
>
> The caller of show_error can now pass an alternative function for mc.
> The Tcl list function turns the transalation into a no-op.
>
> This fixes the
> Error in startup script: invalid command name "mc"
> when attempting to start gitk with Tcl 8.3.
>
> Signed-off-by: Bernt Hansen <bernt@norang.ca>
Thanks, applied.
Paul.
next prev parent reply other threads:[~2009-11-03 11:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-24 20:20 [PATCH 0/2] gitk: Fix error display when Tcl is too old Bernt Hansen
2009-10-24 20:20 ` [PATCH 1/2] gitk: Initialize msgcat before first use Bernt Hansen
2009-10-31 21:34 ` Pat Thoyts
2009-11-01 13:09 ` Bernt Hansen
2009-11-02 12:41 ` [PATCH] Skip translation of wrong Tcl version text Bernt Hansen
2009-11-03 11:31 ` Paul Mackerras [this message]
2009-10-24 20:20 ` [PATCH 2/2] gitk: Provide a default mc function if msgcat is not available Bernt Hansen
2009-10-24 22:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19184.5257.944412.835848@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=bernt@norang.ca \
--cc=git@vger.kernel.org \
--cc=patthoyts@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).