From: Paul Mackerras <paulus@samba.org>
To: Markus Heidelberg <markus.heidelberg@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitk: Fix "git gui blame" invocation when called from topdir
Date: Sat, 14 Nov 2009 22:14:17 +1100 [thread overview]
Message-ID: <19198.37129.682215.327167@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <1257290501-21093-1-git-send-email-markus.heidelberg@web.de>
Markus Heidelberg writes:
> In this case "git rev-parse --git-dir" doesn't return an absolute path,
> but merely ".git", so the selected file has a relative path.
> The function make_relative then tries to make the already relative path
> relative, which results in a path like "../../../../Makefile" with as
> much ".." as the number of parts [pwd] consists of.
>
> This regression was introduced by commit 9712b81 (gitk: Fix bugs in
> blaming code, 2008-12-06), which fixed "git gui blame" when called from
> subdirs.
>
> This also fixes it for bare repositories.
>
> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
Thanks, applied.
Paul.
next prev parent reply other threads:[~2009-11-14 11:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-31 12:09 [PATCH resend] gitk: Fix "git gui blame" invocation when called from topdir Markus Heidelberg
2009-11-03 10:39 ` Paul Mackerras
2009-11-03 23:21 ` [PATCH] " Markus Heidelberg
2009-11-14 11:14 ` Paul Mackerras [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-06-21 17:34 Markus Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19198.37129.682215.327167@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=markus.heidelberg@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).