From: Jason Riedy <ejr@EECS.Berkeley.EDU>
To: merlyn@stonehenge.com (Randal L. Schwartz)
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] Use File::Find rather than find and xargs in git-archimport
Date: Fri, 10 Feb 2006 16:17:00 -0800 [thread overview]
Message-ID: <1939.1139617020@lotus.CS.Berkeley.EDU> (raw)
In-Reply-To: <86k6c2ojx6.fsf@blue.stonehenge.com>
And Randal L. Schwartz writes:
- Jason> + if (-f && !-z && /^.*\.patch$/ && !/{arch}/) {
-
- If that works, it's only accidentally.
Thanks! Not only is the regex wrong, it's applied to the
wrong quantity. Should be on $File::Find::dir. Looks like
the repos I tested against didn't have any Arch state
patches.
I'll fix this, test it on a nastier set of repos, and re-
send. It'll be an hour or so, at least.
Jason
next prev parent reply other threads:[~2006-02-11 0:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-10 23:35 [PATCH 2/3] Use File::Find rather than find and xargs in git-archimport Jason Riedy
2006-02-10 23:47 ` Randal L. Schwartz
2006-02-11 0:17 ` Jason Riedy [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-02-11 2:52 Jason Riedy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1939.1139617020@lotus.CS.Berkeley.EDU \
--to=ejr@eecs.berkeley.edu \
--cc=git@vger.kernel.org \
--cc=merlyn@stonehenge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).