From: Eli Barzilay <eli@barzilay.org>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Eugene Sajine <euguess@gmail.com>,
Bo Yang <struggleyb.nku@gmail.com>,
Jacob Helwig <jacob.helwig@gmail.com>,
git@vger.kernel.org
Subject: Re: Re: git log -M -- filename is not working?
Date: Fri, 14 May 2010 01:05:10 -0400 [thread overview]
Message-ID: <19436.55814.552536.42519@winooski.ccs.neu.edu> (raw)
In-Reply-To: <20100514045522.GE6075@coredump.intra.peff.net>
On May 14, Jeff King wrote:
> [...]
(I didn't get most of that...)
> The only "downside" is that it means --follow actually impacts the diff
> generation by implying --find-copies-harder. And I put downside in
> quotes because it is probably not a big deal. We have already spent the
> CPU time to find the answer, so it is silly not to show it. I can't
> imagine why somebody would want --follow, but would _not_ want rename
> detection in the resulting diff.
...but this seems very reasonable. (In fact, if --follow implies
finding copies and renames, and if it's doing that for diff too, then
it's exactly what I originally wanted.)
> Bo's version of the patch does that optimization. When I clean up the
> patch (probably sometime next week), I'll take those changes.
Thanks!
--
((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay:
http://barzilay.org/ Maze is Life!
next prev parent reply other threads:[~2010-05-14 5:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 18:07 git log -M -- filename is not working? Eugene Sajine
2010-05-07 18:10 ` Jacob Helwig
2010-05-07 18:31 ` Eugene Sajine
2010-05-07 18:37 ` Eli Barzilay
2010-05-07 20:25 ` Matthieu Moy
2010-05-07 20:28 ` Jakub Narebski
2010-05-08 4:44 ` Jeff King
2010-05-08 5:12 ` Eli Barzilay
2010-05-08 5:30 ` Jeff King
2010-05-08 5:39 ` Junio C Hamano
2010-05-08 7:08 ` Eli Barzilay
2010-05-12 11:38 ` Jeff King
2010-05-12 12:01 ` Eli Barzilay
2010-05-12 12:49 ` Jeff King
2010-05-12 13:03 ` Jeff King
2010-05-12 14:35 ` Eli Barzilay
2010-05-12 16:07 ` Bo Yang
2010-05-12 16:45 ` Jeff King
2010-05-13 2:12 ` Bo Yang
2010-05-13 4:39 ` Eli Barzilay
2010-05-14 4:55 ` Jeff King
2010-05-14 5:05 ` Eli Barzilay [this message]
2010-05-12 13:06 ` Bo Yang
2010-05-12 13:09 ` Jeff King
2010-05-12 14:42 ` Eli Barzilay
2010-05-12 14:49 ` Bo Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19436.55814.552536.42519@winooski.ccs.neu.edu \
--to=eli@barzilay.org \
--cc=euguess@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.helwig@gmail.com \
--cc=peff@peff.net \
--cc=struggleyb.nku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).