git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eli Barzilay <eli@barzilay.org>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: gitweb.css
Date: Thu, 8 Jul 2010 13:42:05 -0400	[thread overview]
Message-ID: <19510.3565.336183.72646@winooski.ccs.neu.edu> (raw)
In-Reply-To: <m3y6dmklg0.fsf@localhost.localdomain>

On Jul  8, Jakub Narebski wrote:
> Eli Barzilay <eli@barzilay.org> writes:
> 
> > I've been customizing a gitweb server to fit with the rest of our
> > project pages (the result is http://git.racket-lang.org/).  This was
> > relatively easy to do except for a few places where gitweb.css
> > specifies formatting for generic tags like `body', `table', and `td',
> > which messed up our header.
> > 
> > Maybe it makes sense to localize these styles to to gitweb specific
> > classes?  (I know that I can just use my own css, but the file is big
> > enough that I prefer avoiding manually merging in updates.)
> 
> Can't you just override gitweb's CSS by your own CSS?  Later CSS
> wins.  You can have more than one stylesheet in gitweb
> (@stylesheets).

I know -- and I'm using that.  The problem is if there's a property
that we're not defining, then it won't get overridden -- and doing so
requires knowing what the default value is, and keeping our css
updated for future extensions (eg, if tomorrow you make add
`font-family' to the `table' entry, we'll need to add one too, etc).
And still, this means overriding your settings, which were probably
done for a reason...


> [...]
> I'd rather not add 'gitweb' class (or similar) to every element just
> to have common style for all links, tables, table header cells,
> table cells.

Why not add just a <div class=".gitweb"> container for all gitweb
content, then have css for ".gitweb foo" for anything you want?

-- 
          ((lambda (x) (x x)) (lambda (x) (x x)))          Eli Barzilay:
                    http://barzilay.org/                   Maze is Life!

  reply	other threads:[~2010-07-08 17:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-08  2:43 gitweb.css Eli Barzilay
2010-07-08 16:07 ` gitweb.css Jakub Narebski
2010-07-08 17:42   ` Eli Barzilay [this message]
2010-07-08 18:49     ` gitweb.css Jakub Narebski
2010-07-08 18:57       ` gitweb.css Eli Barzilay
2010-07-08 19:25         ` gitweb.css Jakub Narebski
2010-07-08 19:30           ` gitweb.css Eli Barzilay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19510.3565.336183.72646@winooski.ccs.neu.edu \
    --to=eli@barzilay.org \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).