Git development
 help / color / mirror / Atom feed
From: Li Chen <me@linux.beauty>
To: "Junio C Hamano" <gitster@pobox.com>,
	"phillip.wood" <phillip.wood@dunelm.org.uk>
Cc: "git" <git@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] trailer: append trailers in-process and drop the fork to `interpret-trailers`
Date: Thu, 12 Jun 2025 13:40:07 +0800	[thread overview]
Message-ID: <19762a71ab1.d16b43db461922.5615394257517989238@linux.beauty> (raw)
In-Reply-To: <xmqqa56ejnrk.fsf@gitster.g>

Hi Junio & Phillip,


 ---- On Wed, 11 Jun 2025 23:34:07 +0800  Junio C Hamano <gitster@pobox.com> wrote --- 
 > phillip.wood123@gmail.com writes:
 > 
 > > Exactly - I was expecting to see a refactoring of interpret_trailers()
 > > in builtin/interpret-trailers.c that moved most of the function body
 > > into a new function in trailer.c that added the trailers to an
 > > strbuf. This seems to be a parallel implementation which doesn't sound
 > > like the best plan.
 > >
 > > I'm going to be off the list for a couple of weeks, I'll take a more
 > > detailed look at this series when I'm back

Thanks for your suggestion; I will refactor it in the next version.

Regards,
Li

  reply	other threads:[~2025-06-12  5:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10 12:34 [PATCH v2 0/2] rebase: support --trailer Li Chen
2025-06-10 12:34 ` [PATCH v2 1/2] trailer: append trailers in-process and drop the fork to `interpret-trailers` Li Chen
2025-06-11  0:09   ` Junio C Hamano
2025-06-11  9:15     ` phillip.wood123
2025-06-11 15:34       ` Junio C Hamano
2025-06-12  5:40         ` Li Chen [this message]
2025-06-10 12:34 ` [PATCH v2 2/2] rebase: support --trailer Li Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19762a71ab1.d16b43db461922.5615394257517989238@linux.beauty \
    --to=me@linux.beauty \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox