From: Frank Li <lznuaa@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, msysgit@googlegroups.com
Subject: Re: [PATCH 03/11] Define SNPRINTF_SIZE_CORR 1 when use MSVC build git
Date: Tue, 18 Aug 2009 09:19:26 +0800 [thread overview]
Message-ID: <1976ea660908171819m38d3524ud174a7e76a171e75@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0908171829510.4991@intel-tinevez-2-302>
> How about this instead?
>
> Define SNPRINTF_SIZE_CORR=1 for Microsoft Visual C++
>
> The Microsoft C runtime's vsnprintf function does not add NUL at
> the end of the buffer.
>
> Further, Microsoft deprecated vsnprintf in favor of _vsnprintf, so
> add a #define to that end.
Of course, do you need me change commit comment and resend patch?
>
> The patch is good, although I suspect that the definition of vsnprintf is
> better handled in the precompiler options in .vcproj.
>
If define in .vcproj, it needs copy that to DEBUG\RELEASE and 32bit\64bit (2x2)
4 places. It is easy to miss one.
> Ciao,
> Dscho
>
next prev parent reply other threads:[~2009-08-18 1:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 16:01 [PATCH 01/11] Fix build failure at VC because function declare use old style at regex.c Frank Li
2009-08-17 16:01 ` [PATCH 02/11] Fix declare variable at mid of function Frank Li
2009-08-17 16:01 ` [PATCH 03/11] Define SNPRINTF_SIZE_CORR 1 when use MSVC build git Frank Li
2009-08-17 16:01 ` [PATCH 04/11] Add _MSC_VER predefine macro to make same behaviors with __MINGW32__ Enable MSVC build. MSVC have the save behaviors with msysgit Frank Li
2009-08-17 16:38 ` Johannes Schindelin
2009-08-18 1:29 ` Frank Li
2009-08-18 5:06 ` tom fogal
2009-08-17 16:32 ` [PATCH 03/11] Define SNPRINTF_SIZE_CORR 1 when use MSVC build git Johannes Schindelin
2009-08-18 1:19 ` Frank Li [this message]
2009-08-18 9:31 ` Johannes Schindelin
2009-08-17 16:29 ` [PATCH 02/11] Fix declare variable at mid of function Johannes Schindelin
2009-08-17 16:34 ` Reece Dunn
2009-08-17 19:36 ` Johannes Schindelin
2009-08-18 5:23 ` [msysGit] " Marius Storm-Olsen
2009-08-18 9:34 ` Johannes Schindelin
2009-08-18 16:11 ` Frank Li
2009-08-18 16:52 ` Matthieu Moy
2009-08-19 10:15 ` Johannes Schindelin
2009-08-19 10:55 ` Johannes Sixt
2009-08-19 13:15 ` Johannes Schindelin
2009-08-19 15:21 ` [msysGit] " Johannes Sixt
2009-08-17 19:28 ` Junio C Hamano
2009-08-17 21:00 ` [msysGit] " Johannes Schindelin
2009-08-17 21:38 ` Junio C Hamano
2009-08-17 16:26 ` [PATCH 01/11] Fix build failure at VC because function declare use old style at regex.c Johannes Schindelin
2009-08-18 15:03 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1976ea660908171819m38d3524ud174a7e76a171e75@mail.gmail.com \
--to=lznuaa@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).