* [PATCH] Fix symlink __stdcall problem at MSVC
@ 2009-08-20 13:24 Frank Li
2009-08-20 13:47 ` Johannes Schindelin
0 siblings, 1 reply; 3+ messages in thread
From: Frank Li @ 2009-08-20 13:24 UTC (permalink / raw)
To: git, msysgit; +Cc: Frank Li
MSVC requires that __stdcall be between return value and function name.
Further, all Win32 API definitions look like this:
Signed-off-by: Frank Li <lznuaa@gmail.com>
---
compat/mingw.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/compat/mingw.c b/compat/mingw.c
index fd642e4..4256243 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -1421,7 +1421,7 @@ int link(const char *oldpath, const char *newpath)
int symlink(const char *oldpath, const char *newpath)
{
- typedef BOOL WINAPI (*symlink_fn)(const char*, const char*, DWORD);
+ typedef BOOL (WINAPI *symlink_fn)(const char*, const char*, DWORD);
static symlink_fn create_symbolic_link = NULL;
if (!create_symbolic_link) {
create_symbolic_link = (symlink_fn) GetProcAddress(
--
1.6.4.msysgit.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix symlink __stdcall problem at MSVC
2009-08-20 13:24 [PATCH] Fix symlink __stdcall problem at MSVC Frank Li
@ 2009-08-20 13:47 ` Johannes Schindelin
2009-08-20 14:16 ` Frank Li
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Schindelin @ 2009-08-20 13:47 UTC (permalink / raw)
To: Frank Li; +Cc: git, msysgit
Hi,
On Thu, 20 Aug 2009, Frank Li wrote:
> MSVC requires that __stdcall be between return value and function name.
> Further, all Win32 API definitions look like this:
>
> Signed-off-by: Frank Li <lznuaa@gmail.com>
> ---
Like what? Seems you did not paste my complete commit message.
Ciao,
Dscho
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix symlink __stdcall problem at MSVC
2009-08-20 13:47 ` Johannes Schindelin
@ 2009-08-20 14:16 ` Frank Li
0 siblings, 0 replies; 3+ messages in thread
From: Frank Li @ 2009-08-20 14:16 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: git, msysgit
>
> Like what? Seems you did not paste my complete commit message.
>
Yes, Sorry about this
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-08-20 14:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-20 13:24 [PATCH] Fix symlink __stdcall problem at MSVC Frank Li
2009-08-20 13:47 ` Johannes Schindelin
2009-08-20 14:16 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).