git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Li <lznuaa@gmail.com>
To: git@vger.kernel.org
Subject: possible code error at run_command.c
Date: Mon, 21 Dec 2009 14:46:41 +0800	[thread overview]
Message-ID: <1976ea660912202246k45732bf2p111bbeb78047693e@mail.gmail.com> (raw)

int start_command(struct child_process *cmd)
{
	int need_in, need_out, need_err;
	int fdin[2], fdout[2], fderr[2];
	int failed_errno = failed_errno;

I have not found failed_errno as global variable.
failed_errno = failed_errno means nothing.

It is possible coding error and should be
int failed_errno= 0 or
failed_errno=errno.

             reply	other threads:[~2009-12-21  6:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-21  6:46 Frank Li [this message]
2009-12-21  7:09 ` possible code error at run_command.c Wincent Colaiuta
2009-12-21  7:18 ` Johannes Sixt
2009-12-21  7:29   ` Frank Li
2009-12-21  7:43     ` Johannes Sixt
2009-12-21  8:18       ` Frank Li
2009-12-21  8:30         ` Johannes Sixt
2009-12-21  8:41           ` Erik Faye-Lund
2009-12-21  8:52             ` Johannes Sixt
2009-12-21  9:08               ` Erik Faye-Lund
2009-12-21  9:13               ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1976ea660912202246k45732bf2p111bbeb78047693e@mail.gmail.com \
    --to=lznuaa@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).