From: Frank Li <lznuaa@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, msysGit <msysgit@googlegroups.com>
Subject: Re: http getpass function in msysgit
Date: Wed, 3 Feb 2010 13:48:26 +0800 [thread overview]
Message-ID: <1976ea661002022148s544be10bie912295e04189864@mail.gmail.com> (raw)
In-Reply-To: <7vpr4mrijt.fsf@alter.siamese.dyndns.org>
> - If you look at an environment, why check terminal at all? If the
> calling application wants to specify "here is the way to ask the user
> for a password" with it, why not use it unconditionally?
I just worry about user set such environment accident. Learn it from OpenSSH.
Unconditional is okay for me.
>
> - Why is it HTTP_ASKPASS? If other codepaths (e.g. "ssh passphrase",
> "svn password") that do not have anything to do with HTTP transfer also
> wants that feature,
You can choose environment name you like. I choose HTTP_ASKPASS just
because getpass only used at http.c
ssl_cert_password = getpass("Certificate Password: ");
OpenSSH is separated application and use own SSH_ASKPASS to ask password ...
May GIT_ASKPASS is optional name.
> wouldn't it be easier for the users to specify one
> single "password dialog" helper program, that is launched by various
> parts of git, and ask "I need the HTTP password to access li.org", "I
> need to unlock the ssh key for fl@li.org", etc?
It is nice to use one dialog for all cases. git-svn also have the same problem.
next prev parent reply other threads:[~2010-02-03 5:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 3:18 http getpass function in msysgit Frank Li
2010-02-03 5:32 ` Junio C Hamano
2010-02-03 5:48 ` Frank Li [this message]
2010-02-04 1:28 ` Junio C Hamano
2010-02-04 1:56 ` Frank Li
2010-02-04 2:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1976ea661002022148s544be10bie912295e04189864@mail.gmail.com \
--to=lznuaa@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).