From: Frank Li <lznuaa@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, msysGit <msysgit@googlegroups.com>
Subject: Re: http getpass function in msysgit
Date: Thu, 4 Feb 2010 09:56:57 +0800 [thread overview]
Message-ID: <1976ea661002031756j2c2699b0hf7deb8febdce841b@mail.gmail.com> (raw)
In-Reply-To: <7vaavp3i2n.fsf@alter.siamese.dyndns.org>
>
> - If GIT_ASKPASS is not set:
>
> - If SSH_ASKPASS is present, then use that from getpass() for any and
> all places that would want to get "password" like things;
>
> - Otherwise consult the terminal as before;
>
> - If GIT_ASKPASS is set:
>
> - If SSH_ASKPASS is not set, then export the value of GIT_ASKPASS as
> such as well, so that whenever we spawn "ssh", the same GIT_ASKPASS
> program will be used as a fallback.
>
> That way, if the user already has set up SSH_ASKPASS, we will use the same
> familiar dialog without forcing the user do anything extra. If the user
> only sets GIT_ASKPASS without doing SSH_ASKPASS, we would also use it to
> drive the ssh session. In either case, the user doesn't need to worry
> about multiple configuration or dialog interface.
>
>> It is nice to use one dialog for all cases. git-svn also have the same problem.
>
Can we direct use SSH_ASKPASS for all getpass and don't use GIT_ASKPASS at all?
The logic will be come simple.
next prev parent reply other threads:[~2010-02-04 1:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 3:18 http getpass function in msysgit Frank Li
2010-02-03 5:32 ` Junio C Hamano
2010-02-03 5:48 ` Frank Li
2010-02-04 1:28 ` Junio C Hamano
2010-02-04 1:56 ` Frank Li [this message]
2010-02-04 2:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1976ea661002031756j2c2699b0hf7deb8febdce841b@mail.gmail.com \
--to=lznuaa@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).