From: Frank Li <lznuaa@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH 3/3] fallback SSH_ASKPASS when GIT_ASKPASS not set
Date: Thu, 25 Feb 2010 09:37:07 +0800 [thread overview]
Message-ID: <1976ea661002241737s74e0b9d3q30ba3f6632980fa2@mail.gmail.com> (raw)
In-Reply-To: <7vocje38ll.fsf@alter.siamese.dyndns.org>
> So probably the patch to implement the fallback should be more like
>
> if (SSH_ASKPASS is set but not GIT_ASKPASS)
> set GIT_ASKPASS from SSH_ASKPASS
>
do you means just keep these?
+ if (!getenv("GIT_ASKPASS") && getenv("SSH_ASKPASS"))
+ setenv("GIT_ASKPASS", getenv("SSH_ASKPASS"), 1);
best regards
Frank Li
prev parent reply other threads:[~2010-02-25 1:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 15:15 [PATCH 3/3] fallback SSH_ASKPASS when GIT_ASKPASS not set Frank Li
2010-02-24 15:34 ` Erik Faye-Lund
2010-02-25 4:17 ` Frank Li
2010-02-24 16:24 ` Junio C Hamano
2010-02-25 1:37 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1976ea661002241737s74e0b9d3q30ba3f6632980fa2@mail.gmail.com \
--to=lznuaa@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).