git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Li <lznuaa@gmail.com>
To: kusmabite@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH 3/3] fallback SSH_ASKPASS when GIT_ASKPASS not set
Date: Thu, 25 Feb 2010 12:17:23 +0800	[thread overview]
Message-ID: <1976ea661002242017v318ec3davb62087006d37f5e4@mail.gmail.com> (raw)
In-Reply-To: <40aa078e1002240734u1ef6364fp16fbce50caf575bd@mail.gmail.com>

>
> Since there's a maximum total size of the environment on Windows
> (64kib), perhaps it's better to not increase the environment-size more
> than necessary and instead check both variables when used? I must
> admit doing so gives me a kind of yuck-feeling, but at least it should
> also make non-builtins (like git-svn, which AFAICT is what you're
> fixing) work consistently even if it's not called through the
> git-wrapper...
>

Git-svn use the same way, please read first patch.

  reply	other threads:[~2010-02-25  4:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-24 15:15 [PATCH 3/3] fallback SSH_ASKPASS when GIT_ASKPASS not set Frank Li
2010-02-24 15:34 ` Erik Faye-Lund
2010-02-25  4:17   ` Frank Li [this message]
2010-02-24 16:24 ` Junio C Hamano
2010-02-25  1:37   ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1976ea661002242017v318ec3davb62087006d37f5e4@mail.gmail.com \
    --to=lznuaa@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kusmabite@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).