From: Frank Li <lznuaa@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v2 2/3] git-core: Support retrieving passwords with GIT_ASKPASS
Date: Fri, 26 Feb 2010 18:01:10 +0800 [thread overview]
Message-ID: <1976ea661002260201s75ef6185x3f89742d58f12222@mail.gmail.com> (raw)
In-Reply-To: <4B87797D.7030905@viscovery.net>
>
> You handle the return value in different ways. getpass() returns a pointer
> to a static buffer, but in the 'then' branch you return an allocated
> buffer. Not that it matters a lot, though. You could add a comment that
> you are aware that the memory is leaked.
>
How about my branch also use static buffer, so there are not memory leak.
best regards
Frank Li
prev parent reply other threads:[~2010-02-26 10:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 0:12 [PATCH v2 2/3] git-core: Support retrieving passwords with GIT_ASKPASS Frank Li
2010-02-26 0:50 ` Miklos Vajna
2010-02-26 2:17 ` Frank Li
2010-02-26 7:34 ` Johannes Sixt
2010-02-26 7:50 ` Junio C Hamano
2010-02-26 9:32 ` Johannes Sixt
2010-02-26 17:50 ` Junio C Hamano
2010-02-26 10:01 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1976ea661002260201s75ef6185x3f89742d58f12222@mail.gmail.com \
--to=lznuaa@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).