git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Li <lznuaa@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v5-j6t 2/3] git-core: Support retrieving passwords with  GIT_ASKPASS
Date: Fri, 5 Mar 2010 10:31:18 +0800	[thread overview]
Message-ID: <1976ea661003041831n2573bda2xd0f528e03a1444de@mail.gmail.com> (raw)
In-Reply-To: <201003042059.51516.j6t@kdbg.org>

>
>  I changed the code to make struct strbuf buffer itself static and fixed
>  the error message. I removed the comment about the memory leak again
>  because now the buffer is conceptually static even though behind the
>  scenes it points to allocated memory.
>
>  Frank, I did not test it beyond the test suite. Please test and say
>  no or go.
>

        Thanks.
        I test it. It work rightly with prompted password
appliction(ssh-askpass).


best regards
Frank Li

      reply	other threads:[~2010-03-05  3:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-04 14:36 [PATCH v5 2/3] git-core: Support retrieving passwords with GIT_ASKPASS Frank Li
2010-03-04 18:26 ` Junio C Hamano
2010-03-04 19:59   ` [PATCH v5-j6t " Johannes Sixt
2010-03-05  2:31     ` Frank Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1976ea661003041831n2573bda2xd0f528e03a1444de@mail.gmail.com \
    --to=lznuaa@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j6t@kdbg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).