git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: Michael Rappazzo <rappazzo@gmail.com>
Cc: git@vger.kernel.org, Mark Levedahl <mlevedahl@gmail.com>
Subject: Re: [PATCH v2 1/2] gitk: fix the position of the main main window on initialize
Date: Mon, 22 Sep 2025 08:00:24 +0200	[thread overview]
Message-ID: <199b7665-910a-4f44-a734-ced99bc8cb81@kdbg.org> (raw)
In-Reply-To: <20250920184007.26183-2-rappazzo@gmail.com>

Am 20.09.25 um 20:40 schrieb Michael Rappazzo:
> The main window geometry was only restoring size but not position.
> Use after idle to ensure proper timing on OS's where that is necessary.
> 
> Signed-off-by: Michael Rappazzo <rappazzo@gmail.com>
> ---
>  gitk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/gitk b/gitk
> index 6e4d71d585..95469a8fae 100755
> --- a/gitk
> +++ b/gitk
> @@ -2775,6 +2775,8 @@ proc makewindow {} {
>              }
>              wm geometry . "${w}x$h"
>          }
> +        # Restore full geometry including position after window is mapped
> +        after idle [list wm geometry . $geometry(main)]
>      }
>  
>      if {[info exists geometry(state)] && $geometry(state) eq "zoomed"} {

I have been carrying 22d37f865268 ("Revert "gitk: Only restore window
size from ~/.gitk, not position"", 2008-05-26) since, like, 17 years in
my branch j6t-testing. Perhaps Mark can tell us why b9bee11526ec ("gitk:
Only restore window size from ~/.gitk, not position", 2008-03-10) was
needed...

-- Hannes


  reply	other threads:[~2025-09-22  6:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-20 18:40 [PATCH v2 0/2] gitk: make the 'Tags and Heads' window geometry sticky Michael Rappazzo
2025-09-20 18:40 ` [PATCH v2 1/2] gitk: fix the position of the main main window on initialize Michael Rappazzo
2025-09-22  6:00   ` Johannes Sixt [this message]
2025-09-22 10:16     ` Mark Levedahl
2025-09-20 18:40 ` [PATCH v2 2/2] gitk: make Tags and Heads window geometry sticky Michael Rappazzo
2025-09-22  6:34   ` Johannes Sixt
2025-09-25 12:45     ` Mike Rappazzo
2025-09-28 13:30       ` Mike Rappazzo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=199b7665-910a-4f44-a734-ced99bc8cb81@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=git@vger.kernel.org \
    --cc=mlevedahl@gmail.com \
    --cc=rappazzo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).