Git development
 help / color / mirror / Atom feed
From: Derrick Stolee <derrickstolee@github.com>
To: Lessley Dennington via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Cc: gitster@pobox.com, Lessley Dennington <lessleydennington@gmail.com>
Subject: Re: [PATCH] osx-keychain: fix compiler warning
Date: Tue, 19 Jul 2022 13:30:32 -0400	[thread overview]
Message-ID: <19ab5c2b-6506-18c1-b8c1-b96074442edf@github.com> (raw)
In-Reply-To: <pull.1293.git.1658251503775.gitgitgadget@gmail.com>

On 7/19/2022 1:25 PM, Lessley Dennington via GitGitGadget wrote:
> From: Lessley Dennington <lessleydennington@gmail.com>
> 
> Update git-credential-osxkeychain.c to remove 'format string is not a string
> literal (potentially insecure)' compiler warning by treating the string as
> an argument.

>  	if (!argv[1])
> -		die(usage);
> +		die("%s", usage);

Thanks for preparing this for upstream. I reviewed this change as we
were doing related things in the microsoft/git fork. LGTM here, too.

Thanks,
-Stolee

  reply	other threads:[~2022-07-19 17:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19 17:25 [PATCH] osx-keychain: fix compiler warning Lessley Dennington via GitGitGadget
2022-07-19 17:30 ` Derrick Stolee [this message]
2022-07-19 18:24 ` Junio C Hamano
2022-07-19 18:29 ` Glen Choo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19ab5c2b-6506-18c1-b8c1-b96074442edf@github.com \
    --to=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=lessleydennington@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox