From: Lars Schneider <larsxschneider@gmail.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCHv2 0/3] Travis CI: skip commits with successfully built and tested trees
Date: Sun, 31 Dec 2017 12:27:57 +0100 [thread overview]
Message-ID: <1A70B41A-92D5-48D4-8550-86F56C4DF74F@gmail.com> (raw)
In-Reply-To: <20171231101205.7466-1-szeder.dev@gmail.com>
> On 31 Dec 2017, at 11:12, SZEDER Gábor <szeder.dev@gmail.com> wrote:
>
> This is the second iteration of 'sg/travis-skip-identical-test',
> addressing the comments of Lars and Jonathan:
>
> - Colorize the "Tip of $TRAVIS_BRANCH is exactly at $TAG" message
> in the new patch 1/3.
>
> - Create the cache directory at the beginning of the build process
> (patch 2/3).
>
> - Limit the the cached good trees file size to 1000 records, to
> prevent it from growing too large for git/git's forever living
> integration branches (patch 3/3).
>
> - Colorize the first line of the "skip build job because this tree has
> been tested". Green it is (3/3).
>
> - Removed stray whitespace (3/3).
>
> - Updated an in-code comment, to make clear which code path deals with
> a non-existing good trees file (3/3).
This series looks good to me.
Nice work!
- Lars
prev parent reply other threads:[~2017-12-31 11:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-27 16:49 [PATCH 0/2] Travis CI: skip commits with successfully built and tested trees SZEDER Gábor
2017-12-27 16:49 ` [PATCH 1/2] travis-ci: don't try to create the cache directory unnecessarily SZEDER Gábor
2017-12-27 19:46 ` Jonathan Nieder
2017-12-28 11:04 ` SZEDER Gábor
2017-12-28 18:13 ` Jonathan Nieder
2017-12-27 16:49 ` [PATCH 2/2] travis-ci: record and skip successfully built trees SZEDER Gábor
2017-12-27 19:15 ` Lars Schneider
2017-12-27 23:00 ` SZEDER Gábor
2017-12-27 23:24 ` SZEDER Gábor
2017-12-28 11:16 ` Lars Schneider
2017-12-29 20:03 ` SZEDER Gábor
2017-12-29 20:16 ` SZEDER Gábor
2017-12-30 19:17 ` Lars Schneider
2017-12-27 19:35 ` Lars Schneider
2017-12-28 10:31 ` SZEDER Gábor
2017-12-28 11:12 ` Lars Schneider
2017-12-28 19:01 ` Junio C Hamano
2017-12-31 10:12 ` [PATCHv2 0/3] Travis CI: skip commits with successfully built and tested trees SZEDER Gábor
2017-12-31 10:12 ` [PATCHv2 1/3] travis-ci: print the "tip of branch is exactly at tag" message in color SZEDER Gábor
2017-12-31 10:12 ` [PATCHv2 2/3] travis-ci: create the cache directory early in the build process SZEDER Gábor
2017-12-31 10:12 ` [PATCHv2 3/3] travis-ci: record and skip successfully built trees SZEDER Gábor
2017-12-31 11:27 ` Lars Schneider [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1A70B41A-92D5-48D4-8550-86F56C4DF74F@gmail.com \
--to=larsxschneider@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).