* [RFC] Gitweb: include minified version of js and css files in the repo
@ 2010-03-13 4:31 Mark Rada
2010-03-13 8:26 ` Jakub Narebski
0 siblings, 1 reply; 3+ messages in thread
From: Mark Rada @ 2010-03-13 4:31 UTC (permalink / raw)
To: git
Hi git devs,
I was catching up on the changes to gitweb changes in the
last little while and I noticed an option to pass gitweb.js
through a minifier during the make execution, which I thought
was pretty cool.
However, I was wondering if there were any reasons why the
minified version of the javascript code was not distributed
in the git repository? It seems like you are leaving that
effort to be duplicated a lot by people who compile git
themselves.
—
Mark Rada
markrada26@gmail.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] Gitweb: include minified version of js and css files in the repo
2010-03-13 4:31 [RFC] Gitweb: include minified version of js and css files in the repo Mark Rada
@ 2010-03-13 8:26 ` Jakub Narebski
2010-03-14 13:22 ` Miklos Vajna
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Narebski @ 2010-03-13 8:26 UTC (permalink / raw)
To: Mark Rada; +Cc: git
Mark Rada <markrada26@gmail.com> writes:
> I was catching up on the changes to gitweb changes in the
> last little while and I noticed an option to pass gitweb.js
> through a minifier during the make execution, which I thought
> was pretty cool.
>
> However, I was wondering if there were any reasons why the
> minified version of the javascript code was not distributed
> in the git repository? It seems like you are leaving that
> effort to be duplicated a lot by people who compile git
> themselves.
The reason is that one should not include *generated* files in
version control. We do not include ./configure script (from
configure.ac), we do not include gitweb.min.js (from gitweb.js).
--
Jakub Narebski
Poland
ShadeHawk on #git
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-14 13:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-13 4:31 [RFC] Gitweb: include minified version of js and css files in the repo Mark Rada
2010-03-13 8:26 ` Jakub Narebski
2010-03-14 13:22 ` Miklos Vajna
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).