From: Ben Knoble <ben.knoble@gmail.com>
To: Tyler Cipriani <tyler@tylercipriani.com>
Cc: git@vger.kernel.org,
Srinidhi Kaushik <shrinidhi.kaushik@gmail.com>,
Stefan Haller <lists@haller-berlin.de>,
Phillip Wood <phillip.wood123@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v5 3/3] push: --force-if-includes should allow fast-forward
Date: Wed, 16 Sep 2026 13:53:03 -0400 [thread overview]
Message-ID: <1BCA7C21-AC51-4706-9F2B-27BF2E94A13B@gmail.com> (raw)
In-Reply-To: <CAHLx=On9sSTR+Ei2FmV7YSDtJ85SAzL3x=ALns1vsotn6c8Fiw@mail.gmail.com>
>
> Le 16 sept. 2026 à 11:52, Tyler Cipriani <tyler@tylercipriani.com> a écrit :
>
> On Wed, Sep 16, 2026 at 6:29 AM D. Ben Knoble <ben.knoble@gmail.com> wrote:
>>
>> Hi Tyler,
[snip]
>> Perhaps we want to
>> make "deferred_reject_reason" more clearly indicate that to save
>> future readers headache if they insert code around here? I'm not sure
>> the best way to do that, though, so maybe blaming to the log message
>> will suffice.
>
> I tried to indicate the rationale with comments, but I'm open to
> changing the variable name, too. I felt that the "deferred" in the
> name captured it, but the name also feels a little broad vs. what it
> does.
>
> Before I take a stab at a reroll for commit message updates + variable
> names, I'd like to gather more feedback on the direction and
> implementation of this series.
Yes, I think that’s a good idea :)
> Thanks you for your thoughtful comments, Ben! I've appreciated how
> you've helped me think about this feature.
You’re quite welcome, thank you!
next prev parent reply other threads:[~2026-09-16 17:53 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 21:01 [PATCH 0/2] push: fix --force-if-includes consulting wrong ref Tyler Cipriani
2026-09-04 21:01 ` [PATCH 1/2] push: check pushed ref for --force-if-includes Tyler Cipriani
2026-09-05 18:57 ` Ben Knoble
2026-09-04 21:01 ` [PATCH 2/2] push: fix --force-if-includes detached HEAD advice Tyler Cipriani
2026-09-05 18:59 ` [PATCH 0/2] push: fix --force-if-includes consulting wrong ref Ben Knoble
2026-09-06 20:24 ` Tyler Cipriani
2026-09-08 22:20 ` [PATCH v2 " Tyler Cipriani
2026-09-09 11:59 ` D. Ben Knoble
2026-09-08 22:20 ` [PATCH v2 1/2] push: check pushed ref for --force-if-includes Tyler Cipriani
2026-09-10 18:43 ` Junio C Hamano
2026-09-10 22:08 ` Tyler Cipriani
2026-09-08 22:20 ` [PATCH v2 2/2] push: fix --force-if-includes detached HEAD advice Tyler Cipriani
2026-09-10 23:05 ` [PATCH v3 0/2] push: fix --force-if-includes consulting wrong ref Tyler Cipriani
2026-09-10 23:05 ` [PATCH v3 1/2] push: check pushed ref for --force-if-includes Tyler Cipriani
2026-09-11 6:55 ` Patrick Steinhardt
2026-09-11 22:58 ` Tyler Cipriani
2026-09-11 15:31 ` Junio C Hamano
2026-09-11 23:47 ` Tyler Cipriani
2026-09-10 23:05 ` [PATCH v3 2/2] push: fix --force-if-includes detached HEAD advice Tyler Cipriani
2026-09-11 6:55 ` Patrick Steinhardt
2026-09-11 16:03 ` Junio C Hamano
2026-09-11 15:40 ` Junio C Hamano
2026-09-14 4:00 ` [PATCH v4 0/2] push: check pushed ref for --force-if-includes Tyler Cipriani
2026-09-14 4:00 ` [PATCH v4 1/2] " Tyler Cipriani
2026-09-14 4:00 ` [PATCH v4 2/2] push: fix --force-if-includes non-branch advice Tyler Cipriani
2026-09-14 13:03 ` [PATCH v4 0/2] push: check pushed ref for --force-if-includes D. Ben Knoble
2026-09-14 19:27 ` Tyler Cipriani
2026-09-14 20:52 ` D. Ben Knoble
2026-09-15 23:33 ` [PATCH v5 0/3] " Tyler Cipriani
2026-09-15 23:33 ` [PATCH v5 1/3] " Tyler Cipriani
2026-09-15 23:33 ` [PATCH v5 2/3] push: fix --force-if-includes non-branch advice Tyler Cipriani
2026-09-15 23:33 ` [PATCH v5 3/3] push: --force-if-includes should allow fast-forward Tyler Cipriani
2026-09-16 12:29 ` D. Ben Knoble
2026-09-16 15:52 ` Tyler Cipriani
2026-09-16 17:53 ` Ben Knoble [this message]
2026-09-17 22:43 ` [PATCH v6 0/3] push: check pushed ref for --force-if-includes Tyler Cipriani
2026-09-17 22:43 ` [PATCH v6 1/3] " Tyler Cipriani
2026-09-17 22:43 ` [PATCH v6 2/3] push: fix --force-if-includes non-branch advice Tyler Cipriani
2026-09-17 22:43 ` [PATCH v6 3/3] push: --force-if-includes should allow fast-forward Tyler Cipriani
2026-10-05 21:26 ` [PATCH v6 0/3] push: check pushed ref for --force-if-includes Tyler Cipriani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1BCA7C21-AC51-4706-9F2B-27BF2E94A13B@gmail.com \
--to=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=lists@haller-berlin.de \
--cc=phillip.wood123@gmail.com \
--cc=shrinidhi.kaushik@gmail.com \
--cc=tyler@tylercipriani.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox