From: "Tor Arvid Lund" <torarvid@gmail.com>
To: dhruva <dhruva@ymail.com>
Cc: "Simon Hausmann" <simon@lst.de>,
"Junio C Hamano" <gitster@pobox.com>,
"GIT SCM" <git@vger.kernel.org>,
"Jing Xue" <jingxue@digizenstudio.com>
Subject: Re: PATCH: git-p4 optional handling of RCS keywords
Date: Thu, 11 Sep 2008 08:33:57 +0200 [thread overview]
Message-ID: <1a6be5fa0809102333j3218ada0xb905e3766c7697cd@mail.gmail.com> (raw)
In-Reply-To: <880457.35643.qm@web95006.mail.in2.yahoo.com>
On Thu, Sep 11, 2008 at 6:06 AM, dhruva <dhruva@ymail.com> wrote:
> Hello,
>
>
> Commit message: Modifying RCS keywords prevents submitting to p4 from git due to missing hunks. Optional shrinking of RCS keywords in git-p4. New option git-p4.kwstrip set to true or false controls the behavior..
<snip away the diff>
Me guesses that Junio (who gets loads of patches) would be happy if you do:
1) Squash these changes down to one single commit
2) Run git format-patch -1
3) Send it to the list either with git send-email, or otherwise send
the 0001-<your-commit-summary>.patch to the list directly if your
mailer supports it.
The reason is simply that the maintainer can simply use git am
<your-raw-mail-message-file> to commit it, instead of having to
manually sift through the emails.
Otherwise, this is nice work. Thanks.
-Tor Arvid-
next prev parent reply other threads:[~2008-09-11 6:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-11 4:06 PATCH: git-p4 optional handling of RCS keywords dhruva
2008-09-11 6:33 ` Tor Arvid Lund [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-09-11 9:18 dhruva
2008-09-11 7:13 dhruva
[not found] <646617.59689.qm@web95011.mail.in2.yahoo.com>
2008-09-10 19:18 ` Simon Hausmann
2008-09-10 5:13 PATCH: git-p4 optional handling of RCS keywords [was: Re: git-p4 and keyword expansion] dhruva
2008-09-10 5:35 ` PATCH: git-p4 optional handling of RCS keywords Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a6be5fa0809102333j3218ada0xb905e3766c7697cd@mail.gmail.com \
--to=torarvid@gmail.com \
--cc=dhruva@ymail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jingxue@digizenstudio.com \
--cc=simon@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).