From: Tom Hughes <tom@compton.nu>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, chriscool@tuxfamily.org, jonathantanmy@google.com
Subject: Re: [PATCH] promisor-remote: add promisor.quiet configuration option
Date: Sat, 25 May 2024 11:29:13 +0100 [thread overview]
Message-ID: <1b10454e-c5ad-4ce3-a724-27306ee8824c@compton.nu> (raw)
In-Reply-To: <20240525052946.GD1895047@coredump.intra.peff.net>
On 25/05/2024 06:29, Jeff King wrote:
> On Thu, May 23, 2024 at 02:19:26PM +0100, Tom Hughes wrote:
>
>> Add a configuration optione to allow output from the promisor
>> fetching objects to be suppressed/
>>
>> This allows us to stop commands like git blame being swamped
>> with progress messages and gc notifications from the promisor
>> when used in a partial clone.
>
> I'm not at all opposed to providing a way to suppress this, but I feel
> like in the long run, the more fundamental issue is that git-blame kicks
> off a zillion fetches as it traverses. That's not only ugly but it's
> also horribly inefficient.
This is true. One thing I found that makes things a lot more
efficient if you're using ssh as the transport is to enable
persistent multiplexing in .ssh/config with something like:
Host git.example.com
ControlMaster auto
ControlPath /run/user/%i/ssh/control.%C
ControlPersist 1m
SendEnv GIT_PROTOCOL
which avoids each fetch having to setup and authenticate a
new ssh session.
> In an ideal world we'd queue all of the blobs we need, do a single
> fetch, and then compute the blame on the result. That's probably easier
> said than done, though we have done it in other spots (e.g., for
> checkout).
That would certainly be an excellent improvement, yes.
Tom
--
Tom Hughes (tom@compton.nu)
http://compton.nu/
next prev parent reply other threads:[~2024-05-25 10:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 13:19 [PATCH] promisor-remote: add promisor.quiet configuration option Tom Hughes
2024-05-23 22:23 ` Junio C Hamano
2024-05-24 8:31 ` Tom Hughes
2024-05-24 9:09 ` [PATCH v2] " Tom Hughes
2024-05-24 18:06 ` Junio C Hamano
2024-05-25 10:10 ` Tom Hughes
2024-05-25 10:09 ` [PATCH v3] " Tom Hughes
2024-05-25 5:29 ` [PATCH] " Jeff King
2024-05-25 10:29 ` Tom Hughes [this message]
2024-05-29 9:36 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b10454e-c5ad-4ce3-a724-27306ee8824c@compton.nu \
--to=tom@compton.nu \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).