Re: [PATCH 1/2] Introduces xmkstemp()

["Carlos Rica" <jasampler@gmail.com>]

2007/8/15, Luiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>:
>
>  Hi Carlos,
>
> Em Wed, 15 Aug 2007 17:11:02 +0200
> "Carlos Rica" <jasampler@gmail.com> escreveu:
>
> | 2007/8/14, Luiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>:
> | >
> | > This is a wrapper for mkstemp() that performs error checking and
> | > calls die() when an error occur.
> |
> | I think that it is related with the git_mkstemp() function in path.c.
>
>  Yeah, you right.
>
> | Perhaps we should use xmkstemp inside that function too, since
> | it is only used in diff.c and after the call it also dies when fd<0.
>
>  Actually, git_mkstemp() is also called by your builtin-verify-tag.c
> program and the function which calls it (run_gpg_verify()) doesn't
> die() on error.

Oh, yeah, I had an old version here. I even don't know if there is need
for verifying more than one tag in one command. When more than
one tag is verified, the return value says nothing about what tag or
tags failed, it is just the same as it would be if the program exited
on the first not verifiable tag, so perhaps it could do that.