git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Carlos Rica" <jasampler@gmail.com>
To: "Pierre Habouzit" <madcoder@debian.org>, git@vger.kernel.org
Subject: Re: Wishlist: Please add --author to git-tag
Date: Thu, 31 Jan 2008 23:49:24 +0100	[thread overview]
Message-ID: <1b46aba20801311449l774a6213kc33c49c0682c0228@mail.gmail.com> (raw)
In-Reply-To: <20080131193550.GB10905@artemis.madism.org>

On Jan 31, 2008 8:35 PM, Pierre Habouzit <madcoder@debian.org> wrote:
> On Thu, Jan 31, 2008 at 05:27:31PM +0000, Daniel Baumann wrote:
> > Hi,
> >
> > git commit supports --author to overwrite the author information on a
> > particular commit; it would be nice if git tag would offer the same.
>
>   Meanwhile,
>
>   GIT_AUTHOR_NAME="John Doe" GIT_AUTHOR_EMAIL=luser@example.com git tag

That didn't work for me, but perhaps I'm not understanding what this user wants
to do. I think it is about to create a tag object having another
author different from committer.

In such case, and looking at builtin-commit.c, I see that the code needed
could came from the function determine_author_info(), just the part using
force_author variable, to be added in the create_tag() function from
builtin-tag.c.

The only thing I don't know is if this should be different from
git-commit in which
both "author" and "committer" fields are supplied and only "author" can be
changed this way, preserving the committer. In git-tag, only the committer is
included in the tag object, written as the "tagger".

Please, correct me if I'm wrong.

Regards.
Carlos.

  reply	other threads:[~2008-01-31 22:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-31 17:27 Wishlist: Please add --author to git-tag Daniel Baumann
2008-01-31 19:35 ` Pierre Habouzit
2008-01-31 22:49   ` Carlos Rica [this message]
2008-01-31 23:48     ` Johannes Schindelin
2008-02-01 14:48       ` Carlos Rica
2008-02-16 19:49 ` Rhodes, Kate
2008-02-18  0:00   ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b46aba20801311449l774a6213kc33c49c0682c0228@mail.gmail.com \
    --to=jasampler@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=madcoder@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).