Wishlist: Please add --author to git-tag

Wishlist: Please add --author to git-tag

[Daniel Baumann]

Hi,

git commit supports --author to overwrite the author information on a
particular commit; it would be nice if git tag would offer the same.

Regards,
Daniel

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/

Re: Wishlist: Please add --author to git-tag

[Pierre Habouzit]

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

On Thu, Jan 31, 2008 at 05:27:31PM +0000, Daniel Baumann wrote:
> Hi,
> 
> git commit supports --author to overwrite the author information on a
> particular commit; it would be nice if git tag would offer the same.

  Meanwhile,

  GIT_AUTHOR_NAME="John Doe" GIT_AUTHOR_EMAIL=luser@example.com git tag

  Will work
-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: Wishlist: Please add --author to git-tag

[Carlos Rica]

On Jan 31, 2008 8:35 PM, Pierre Habouzit <madcoder@debian.org> wrote:
> On Thu, Jan 31, 2008 at 05:27:31PM +0000, Daniel Baumann wrote:
> > Hi,
> >
> > git commit supports --author to overwrite the author information on a
> > particular commit; it would be nice if git tag would offer the same.
>
>   Meanwhile,
>
>   GIT_AUTHOR_NAME="John Doe" GIT_AUTHOR_EMAIL=luser@example.com git tag

That didn't work for me, but perhaps I'm not understanding what this user wants
to do. I think it is about to create a tag object having another
author different from committer.

In such case, and looking at builtin-commit.c, I see that the code needed
could came from the function determine_author_info(), just the part using
force_author variable, to be added in the create_tag() function from
builtin-tag.c.

The only thing I don't know is if this should be different from
git-commit in which
both "author" and "committer" fields are supplied and only "author" can be
changed this way, preserving the committer. In git-tag, only the committer is
included in the tag object, written as the "tagger".

Please, correct me if I'm wrong.

Regards.
Carlos.

Re: Wishlist: Please add --author to git-tag

[Johannes Schindelin]

Hi,

On Thu, 31 Jan 2008, Carlos Rica wrote:

> On Jan 31, 2008 8:35 PM, Pierre Habouzit <madcoder@debian.org> wrote:
> > On Thu, Jan 31, 2008 at 05:27:31PM +0000, Daniel Baumann wrote:
> >
> > > git commit supports --author to overwrite the author information on 
> > > a particular commit; it would be nice if git tag would offer the 
> > > same.
> >
> >   Meanwhile,
> >
> >   GIT_AUTHOR_NAME="John Doe" GIT_AUTHOR_EMAIL=luser@example.com git tag
> 
> That didn't work for me,

Hey jasam, good to see you again.

I think that you have to use "-s" or "-a" for the author information to 
take effect (IOW a lightweight tag will not pick it up, since it is only a 
41-byte file, and does not change the object database).

Ciao,
Dscho

Re: Wishlist: Please add --author to git-tag

[Carlos Rica]

On Feb 1, 2008 12:48 AM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> On Thu, 31 Jan 2008, Carlos Rica wrote:
>
> > On Jan 31, 2008 8:35 PM, Pierre Habouzit <madcoder@debian.org> wrote:
> > > On Thu, Jan 31, 2008 at 05:27:31PM +0000, Daniel Baumann wrote:
> > >
> > > > git commit supports --author to overwrite the author information on
> > > > a particular commit; it would be nice if git tag would offer the
> > > > same.
> > >
> > >   Meanwhile,
> > >
> > >   GIT_AUTHOR_NAME="John Doe" GIT_AUTHOR_EMAIL=luser@example.com git tag
> >
> > That didn't work for me,
>
> Hey jasam, good to see you again.
>
> I think that you have to use "-s" or "-a" for the author information to
> take effect (IOW a lightweight tag will not pick it up, since it is only a
> 41-byte file, and does not change the object database).

This way it doesn't work for me either. You know, the tag object has
only a "tagger", who is always the committer. Currently, I'm inspecting
the resulting object using "git cat-file tag t". I cannot find where that author
name specified in the command line should be stored for tags.

It is nice to see you too!
Carlos

Re: Wishlist: Please add --author to git-tag

[Rhodes, Kate]

On Jan 31, 2008, at 12:27 PM, Daniel Baumann wrote:

> git commit supports --author to overwrite the author information on a
> particular commit; it would be nice if git tag would offer the same.

What are the implications of this on the GPG signature aspect of git- 
tag (desired or otherwise)?

If you were committing someone else's tag wouldn't you want to sign  
not only the commit, but their signature on the commit?

Ignoring the GPG issue, I'm just not seeing the benefit to having an  
author AND a committer on a tag. I mean... it's a *tag*. The only  
value I see in having any name associated with a tag is knowing who to  
point the finger at when the wrong thing gets tagged. But, I don't see  
any authorship aspect to the concept of a tag. To me it's more: "Bob"  
set it and it points to this. The end.

What you're proposing sounds more like: "Bob" said to set it and then  
"Mary" did, because Bob said to.

P.S.  When the right thing is tagged there's generally no need to know  
who did it. I don't care if Linus tags the latest kernel release or  
one of his lieutenants. All I care is that everyone's in agreement  
that whatever that tag points to is the next release. Who tags  
something doesn't change the value of what was tagged.

-masukomi

Re: Wishlist: Please add --author to git-tag

[Nicolas Pitre]

On Sat, 16 Feb 2008, Rhodes, Kate wrote:

> 
> On Jan 31, 2008, at 12:27 PM, Daniel Baumann wrote:
> 
> > git commit supports --author to overwrite the author information on a
> > particular commit; it would be nice if git tag would offer the same.
> 
> What are the implications of this on the GPG signature aspect of git-tag
> (desired or otherwise)?
> 
> If you were committing someone else's tag wouldn't you want to sign not only
> the commit, but their signature on the commit?
> 
> Ignoring the GPG issue, I'm just not seeing the benefit to having an author
> AND a committer on a tag. I mean... it's a *tag*. The only value I see in
> having any name associated with a tag is knowing who to point the finger at
> when the wrong thing gets tagged. But, I don't see any authorship aspect to
> the concept of a tag. To me it's more: "Bob" set it and it points to this. The
> end.
> 
> What you're proposing sounds more like: "Bob" said to set it and then "Mary"
> did, because Bob said to.

And in that case this information can be contained in the tag text body 
itself.


Nicolas