From: "Carlos Rica" <jasampler@gmail.com>
To: "Alex Riesen" <raa.lkml@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] Make builtin-reset.c use parse_options.
Date: Sun, 2 Mar 2008 19:40:09 +0100 [thread overview]
Message-ID: <1b46aba20803021040ofec56b9q120a654a192eec09@mail.gmail.com> (raw)
In-Reply-To: <20080302155541.GH2973@steel.home>
On Sun, Mar 2, 2008 at 4:55 PM, Alex Riesen <raa.lkml@gmail.com> wrote:
>
> "static const struct option options[] = {"
The other files using parse_options have only "static", or nothing.
To make "options" static, then reset_type and quiet should be
static too, otherwise it cannot compile (in my system).
I don't know benefits of making all of them "static".
Has this been discussed previously?
next prev parent reply other threads:[~2008-03-02 18:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-01 16:29 [PATCH] Make builtin-reset.c use parse_options Carlos Rica
2008-03-02 2:53 ` Junio C Hamano
2008-03-02 12:37 ` Carlos Rica
2008-03-02 16:18 ` Junio C Hamano
2008-03-03 14:07 ` Carlos Rica
2008-03-03 17:07 ` Pierre Habouzit
2008-03-03 22:40 ` Junio C Hamano
2008-03-04 9:45 ` Pierre Habouzit
2008-03-02 16:32 ` Johannes Schindelin
2008-03-02 9:40 ` Alex Riesen
2008-03-02 12:54 ` Carlos Rica
2008-03-02 15:55 ` Alex Riesen
2008-03-02 18:40 ` Carlos Rica [this message]
2008-03-02 21:38 ` Alex Riesen
2008-03-03 14:39 ` Carlos Rica
-- strict thread matches above, loose matches on Subject: below --
2008-03-04 22:11 Carlos Rica
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b46aba20803021040ofec56b9q120a654a192eec09@mail.gmail.com \
--to=jasampler@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).