From: "Carlos Rica" <jasampler@gmail.com>
To: "Brandon Casey" <casey@nrlssc.navy.mil>
Cc: "Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] mktag.c: improve verification of tagger field and tests
Date: Wed, 26 Mar 2008 12:21:57 +0100 [thread overview]
Message-ID: <1b46aba20803260421t4db4987gc6fc8b2e556032e0@mail.gmail.com> (raw)
In-Reply-To: <47E99B98.1060506@nrlssc.navy.mil>
On Wed, Mar 26, 2008 at 1:40 AM, Brandon Casey <casey@nrlssc.navy.mil> wrote:
> Well, since I looked at this code and used it in filter-branch, I figured I
> should fix the verification code for the tagger field (even though it's
> probably dieing soon).
>
> I'm thinking this utility should be fairly strict about the format it accepts.
Why not using git-tag to make tags in filter-branch?
git-mktag was used in git-tag.sh before convert it into
builtin-tag.c, and I didn't know that anyone was using it.
I agree that, if this program exists and it is used,
we should double-check the accepted format and data,
so this patch is a good addition.
However, I think that we should progressively deprecate its
use to avoid mantaining two different ways for creating tags,
so you must have a very good reason to keep using
this tool in a script...
Regards
--
Carlos
next prev parent reply other threads:[~2008-03-26 11:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1206490795-13247-1-git-send-email-casey@nrlssc.navy.mil>
2008-03-26 0:40 ` [PATCH] mktag.c: improve verification of tagger field and tests Brandon Casey
2008-03-26 0:44 ` Brandon Casey
2008-03-26 11:21 ` Carlos Rica [this message]
2008-03-26 16:26 ` Brandon Casey
2008-03-26 16:37 ` Brandon Casey
2008-03-26 16:45 ` Junio C Hamano
2008-03-26 21:03 ` Brandon Casey
2008-03-27 16:16 ` [PATCH v2] " Brandon Casey
2008-03-31 8:40 ` Junio C Hamano
2008-03-31 16:04 ` Brandon Casey
2008-03-31 23:25 ` [PATCH] mktag.c: tweak validation of tagger field and adjust test script Brandon Casey
2008-04-01 5:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b46aba20803260421t4db4987gc6fc8b2e556032e0@mail.gmail.com \
--to=jasampler@gmail.com \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).