git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Carlos Rica <jasampler@gmail.com>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] Tests: use test_cmp instead of diff where possible
Date: Tue, 17 Mar 2009 14:02:37 +0100	[thread overview]
Message-ID: <1b46aba20903170602j79735631uf20e0a729e69c4b@mail.gmail.com> (raw)
In-Reply-To: <1237124036-1348-1-git-send-email-vmiklos@frugalware.org>

On Sun, Mar 15, 2009 at 2:33 PM, Miklos Vajna <vmiklos@frugalware.org> wrote:
> Several old tests were written before test_cmp was introduced, convert
> these to test_cmp.

What about the current other calls to cmp? I don't know if they should
be changed too. Are they just the subject of another future change or
have a different purpose? I recently used test_cmp in a test full of
cmp calls (t1300-repo-config.sh).

  parent reply	other threads:[~2009-03-17 13:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-15 13:33 [PATCH] Tests: use test_cmp instead of diff where possible Miklos Vajna
2009-03-15 18:42 ` René Scharfe
2009-03-16 20:18   ` Miklos Vajna
2009-03-17  8:28 ` Jeff King
2009-03-17 13:02 ` Carlos Rica [this message]
2009-03-17 13:21   ` Miklos Vajna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b46aba20903170602j79735631uf20e0a729e69c4b@mail.gmail.com \
    --to=jasampler@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=vmiklos@frugalware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).