Problem with filename containing '?'

Problem with filename containing '?'

[Kurt Ablinger]

Hello,

in Linux the git-client accepts (add, commit, push) files with '?' (questionmark)  in its name.

When cloning such a repository into Eclipse (eGit/jGit) the repository-clone is rejected with an 'Invalid Path'-message with the ?-filename.

Under Linux it is possible to create a clone (the same git-binary used to checkin the ?-file) without any message.
But the directory containing the ?-file is silently discarded whatever you checkout (master/HEAD, first or any other commit containing this file).

Git-version is 2.17.0
Linux - Cent/OS: 2.6.32-754.10.1.el6.x86_64 - GNU/Linux

More information needed ?

Greetings and a have nice weekend
Kurt

Re: Problem with filename containing '?'

[Jeff King]

On Fri, Mar 29, 2019 at 01:10:19PM +0000, Kurt Ablinger wrote:

> in Linux the git-client accepts (add, commit, push) files with '?' (questionmark)  in its name.
> 
> When cloning such a repository into Eclipse (eGit/jGit) the
> repository-clone is rejected with an 'Invalid Path'-message with the
> ?-filename.
> 
> Under Linux it is possible to create a clone (the same git-binary used
> to checkin the ?-file) without any message.
> But the directory containing the ?-file is silently discarded whatever
> you checkout (master/HEAD, first or any other commit containing this
> file).

It seems to work fine for me with a few simple exercises:

  git init repo
  cd repo
  mkdir subdir
  echo foo >'subdir/bar?'
  git add .
  git commit -m 'file with question mark in name'

  git clone --no-local . child
  cd child
  ls -l
  echo changes >'subdir/bar?'
  git commit -am 'changes'
  git show

It also seems to clone fine with jgit:

  jgit clone $PWD/repo jgit-clone

Can you show us more exactly what you're running, and what doesn't work?

Also, one other question: are you sure it's actually a question mark in
the name? If there are non-ascii garbage characters, "ls" will typically
show a question mark when output is going to the terminal. E.g.:

  $ echo foo >"$(printf 'funny\1char')"
  $ ls
  funny?char
  $ ls | cat -A
  funny^Achar$
  $ ls | xxd
  00000000: 6675 6e6e 7901 6368 6172 0a              funny.char.

If it's some more exotic character, then that may be why jgit rejects
it.

-Peff

AW: Problem with filename containing '?'

[Kurt Ablinger]

Good morning,

sorry to waste your time - my check was incomplete - the file in question is there.

But the problem with eGit/jGit on Windows (Eclipse) persists. I did not check jGit in linux.

The problem seems to be, that linux accepts ? in filenames - but windows does not - so no problem wit git (native or java).

Anyway - maybe this could be an option for a future version of git:

	accept only 'compatible' file/path-names
or
	valid file/path-name-pattern

this could be useful for usage on different platforms.

Sorry again, thanks and greetings
Kurt


-----Ursprüngliche Nachricht-----
Von: Jeff King <peff@peff.net> 
Gesendet: Freitag, 29. März 2019 14:34
An: Kurt Ablinger <kurt.ablinger@bs-ag.com>
Cc: git@vger.kernel.org
Betreff: Re: Problem with filename containing '?'

On Fri, Mar 29, 2019 at 01:10:19PM +0000, Kurt Ablinger wrote:

> in Linux the git-client accepts (add, commit, push) files with '?' (questionmark)  in its name.
> 
> When cloning such a repository into Eclipse (eGit/jGit) the 
> repository-clone is rejected with an 'Invalid Path'-message with the 
> ?-filename.
> 
> Under Linux it is possible to create a clone (the same git-binary used 
> to checkin the ?-file) without any message.
> But the directory containing the ?-file is silently discarded whatever 
> you checkout (master/HEAD, first or any other commit containing this 
> file).

It seems to work fine for me with a few simple exercises:

  git init repo
  cd repo
  mkdir subdir
  echo foo >'subdir/bar?'
  git add .
  git commit -m 'file with question mark in name'

  git clone --no-local . child
  cd child
  ls -l
  echo changes >'subdir/bar?'
  git commit -am 'changes'
  git show

It also seems to clone fine with jgit:

  jgit clone $PWD/repo jgit-clone

Can you show us more exactly what you're running, and what doesn't work?

Also, one other question: are you sure it's actually a question mark in the name? If there are non-ascii garbage characters, "ls" will typically show a question mark when output is going to the terminal. E.g.:

  $ echo foo >"$(printf 'funny\1char')"
  $ ls
  funny?char
  $ ls | cat -A
  funny^Achar$
  $ ls | xxd
  00000000: 6675 6e6e 7901 6368 6172 0a              funny.char.

If it's some more exotic character, then that may be why jgit rejects it.

-Peff