From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Matthew Bystrin" <dev.mbstr@gmail.com>, git@vger.kernel.org
Cc: "Lessley Dennington" <lessleydennington@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Elijah Newren" <newren@gmail.com>,
"Phillip Wood" <phillip.wood123@gmail.com>,
"idriss fekir" <mcsm224@gmail.com>,
"Joey Salazar" <jgsal@protonmail.com>
Subject: Re: [PATCH] git: fix paginate handling for commands with DELAY_PAGER_CONFIG
Date: Fri, 22 Nov 2024 19:50:45 +0100 [thread overview]
Message-ID: <1d3aa75d-e816-4544-b10a-ab1a215dcd83@app.fastmail.com> (raw)
In-Reply-To: <20241120101741.8225-1-dev.mbstr@gmail.com>
I was originally not going to nitpick this in case the patch would go through
review (not to disrupt).
On Wed, Nov 20, 2024, at 11:17, Matthew Bystrin wrote:
> Calling commands using editor in terminal with `--paginate` option will
> break things. For example `git --paginate config --edit`. Add extra
> check to ignore paginate flag in case command have DELAY_PAGER_CONFIG
> set.
>
> Relates: cd878a206e8c (t7006: add tests for how git config paginates)
Trailers in this project usually credit/mention people. Related commits tend to
be mentioned in the body (the rest of the body) of the commit message.
> Signed-off-by: Matthew Bystrin <dev.mbstr@gmail.com>
--
Kristoffer Haugsbakk
prev parent reply other threads:[~2024-11-22 18:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 10:17 [PATCH] git: fix paginate handling for commands with DELAY_PAGER_CONFIG Matthew Bystrin
2024-11-21 21:50 ` Martin Ågren
2024-11-22 17:21 ` Junio C Hamano
2024-11-22 18:13 ` Matthew Bystrin
2024-11-25 2:21 ` Junio C Hamano
2024-11-25 10:55 ` Martin Ågren
2024-11-28 22:27 ` Matthew Bystrin
2024-11-22 18:50 ` Kristoffer Haugsbakk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d3aa75d-e816-4544-b10a-ab1a215dcd83@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail.com \
--cc=avarab@gmail.com \
--cc=dev.mbstr@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jgsal@protonmail.com \
--cc=lessleydennington@gmail.com \
--cc=mcsm224@gmail.com \
--cc=newren@gmail.com \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).