From: Han-Wen Nienhuys <hanwen@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Simon Hausmann <simon@lst.de>,
git@vger.kernel.org, Sam Hocevar <sam@zoy.org>
Subject: Re: [PATCH] git-p4: improve performance with large files
Date: Thu, 5 Mar 2009 22:25:48 -0300 [thread overview]
Message-ID: <1d48f7010903051725v510f99f0h2a05b9381ff75ac1@mail.gmail.com> (raw)
In-Reply-To: <7vzlfzwiyn.fsf@gitster.siamese.dyndns.org>
I don't understand the point of trying to save the 32 mb, if people
are sending you blobs that are that large.
The approach to avoid sequences of appends looks sound.
On Thu, Mar 5, 2009 at 10:14 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> ... The ideal solution is to use a generator and refactor the commit
>> handling as a stream. I am working on that but it involves deeper
>> changes, so as I am not sure it will be accepted, I'm providing the
>> attached compromise patch first. At least it solves the appaling speed
>> issue. I tuned it so that it never uses more than 32 MiB extra memory.
>> + text += ''.join(data)
>> + del data
i'd say
data = []
add a comment that you're trying to save memory. There is no reason to
remove data from the namespace.
--
Han-Wen Nienhuys
Google Engineering Belo Horizonte
hanwen@google.com
next prev parent reply other threads:[~2009-03-06 1:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 21:54 [PATCH] git-p4: improve performance with large files Sam Hocevar
2009-03-04 23:05 ` thestar
2009-03-05 17:23 ` Sam Hocevar
2009-03-06 0:01 ` thestar
2009-03-06 1:14 ` Junio C Hamano
2009-03-06 1:25 ` Han-Wen Nienhuys [this message]
2009-03-06 8:53 ` Sam Hocevar
2009-03-06 9:42 ` Junio C Hamano
2009-03-06 10:13 ` [PATCH v4] " Sam Hocevar
2009-03-07 12:25 ` [PATCH v5] git-p4: improve performance when importing huge files by reducing the number of string concatenations while constraining memory usage Sam Hocevar
-- strict thread matches above, loose matches on Subject: below --
2009-03-06 15:53 [PATCH] git-p4: remove unnecessary semicolons at end of lines Sam Hocevar
2009-03-06 16:55 ` Brandon Casey
2009-03-06 17:11 ` msysgit corrupting commit messages? Sam Hocevar
2009-03-07 2:48 ` Johannes Schindelin
2009-03-07 12:26 ` [PATCH v2] git-p4: remove unnecessary semicolons at end of lines Sam Hocevar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d48f7010903051725v510f99f0h2a05b9381ff75ac1@mail.gmail.com \
--to=hanwen@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sam@zoy.org \
--cc=simon@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).