git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiang Xin <worldhello.net@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Git List" <git@vger.kernel.org>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	"Jonathan Nieder" <jrnieder@gmail.com>,
	"Stefano Lattarini" <stefano.lattarini@gmail.com>,
	"Martin von Zweigbergk" <martin.von.zweigbergk@gmail.com>,
	"Jiang Xin" <worldhello.net@gmail.com>
Subject: [PATCH v5 3/7] i18n: Rewrite gettext messages start with dash
Date: Wed, 25 Jul 2012 16:34:08 +0800	[thread overview]
Message-ID: <1ddee15de2edd59f870023ea25cefb5846daeba4.1343205009.git.worldhello.net@gmail.com> (raw)
In-Reply-To: <a8429a6fed3eb0d83d92f798ebf8241a0eeb49c1.1343205009.git.worldhello.net@gmail.com>
In-Reply-To: <cover.1343205009.git.worldhello.net@gmail.com>

Gettext message in a shell script should not start with '-', one
workaround is adding '--' between gettext and the message, like:

    gettext -- "--exec option ..."

But due to a bug in the xgettext extraction, xgettext can not
extract the actual message for this case. Rewriting the message
is a simpler and better solution.

Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Reported-by: Vincent van Ravesteijn <vfr@lyx.org>
Reviewed-by: Stefano Lattarini <stefano.lattarini@gmail.com>
---
 git-rebase.sh                 | 2 +-
 git-submodule.sh              | 2 +-
 t/t3404-rebase-interactive.sh | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/git-rebase.sh b/git-rebase.sh
index 8710d..705bd 100755
--- a/git-rebase.sh
+++ b/git-rebase.sh
@@ -317,7 +317,7 @@ test $# -gt 2 && usage
 if test -n "$cmd" &&
    test "$interactive_rebase" != explicit
 then
-	die "$(gettext -- "--exec option must be used with --interactive option")"
+	die "$(gettext "The --exec option must be used with the --interactive option")"
 fi
 
 if test -n "$action"
diff --git a/git-submodule.sh b/git-submodule.sh
index dba4d..5b019 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -748,7 +748,7 @@ cmd_summary() {
 	if [ -n "$files" ]
 	then
 		test -n "$cached" &&
-		die "$(gettext -- "--cached cannot be used with --files")"
+		die "$(gettext "The --cached option cannot be used with the --files option")"
 		diff_cmd=diff-files
 		head=
 	fi
diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
index 8078..f206a 100755
--- a/t/t3404-rebase-interactive.sh
+++ b/t/t3404-rebase-interactive.sh
@@ -858,7 +858,7 @@ test_expect_success 'rebase -ix with --autosquash' '
 test_expect_success 'rebase --exec without -i shows error message' '
 	git reset --hard execute &&
 	test_must_fail git rebase --exec "git show HEAD" HEAD~2 2>actual &&
-	echo "--exec option must be used with --interactive option" >expected &&
+	echo "The --exec option must be used with the --interactive option" >expected &&
 	test_i18ncmp expected actual
 '
 
-- 
1.7.12.rc0.16.gf4916ac

  reply	other threads:[~2012-07-25  8:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-25  8:34 [PATCH v5 0/7] i18n for git-am, git-rebase and git-merge Jiang Xin
2012-07-25  8:34 ` [PATCH v5 1/7] i18n: New keywords for xgettext extraction from sh Jiang Xin
2012-07-25  8:34   ` [PATCH v5 2/7] i18n: rebase: mark messages for translation Jiang Xin
2012-07-25  8:34     ` Jiang Xin [this message]
2012-07-25  8:34       ` [PATCH v5 4/7] Remove obsolete LONG_USAGE which breaks xgettext Jiang Xin
2012-07-25  8:34         ` [PATCH v5 5/7] i18n: am: mark more strings for translation Jiang Xin
2012-07-25  8:34           ` [PATCH v5 6/7] Remove dead code which contains bad gettext block Jiang Xin
2012-07-25  8:34             ` [PATCH v5 7/7] i18n: merge-recursive: mark strings for translation Jiang Xin
2012-07-25 11:30             ` [PATCH v5 6/7] Remove dead code which contains bad gettext block Jonathan Nieder
2012-07-25 13:31               ` Jiang Xin
2012-07-26 12:21                 ` Nguyen Thai Ngoc Duy
  -- strict thread matches above, loose matches on Subject: below --
2012-07-25 14:44 [PATCH v5 0/7] i18n for git-am, git-rebase and git-merge Jiang Xin
2012-07-25 14:44 ` [PATCH v5 1/7] i18n: New keywords for xgettext extraction from sh Jiang Xin
2012-07-25 14:44   ` [PATCH v5 2/7] i18n: rebase: mark messages for translation Jiang Xin
2012-07-25 14:44     ` [PATCH v5 3/7] i18n: Rewrite gettext messages start with dash Jiang Xin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ddee15de2edd59f870023ea25cefb5846daeba4.1343205009.git.worldhello.net@gmail.com \
    --to=worldhello.net@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=martin.von.zweigbergk@gmail.com \
    --cc=pclouds@gmail.com \
    --cc=stefano.lattarini@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).