From: lists@haller-berlin.de (Stefan Haller)
To: laksvij@gmail.com (Vijay Lakshminarayanan)
Cc: git@drmicha.warpmail.net (Michael J Gruber), git@vger.kernel.org
Subject: Re: rev-list --cherry-pick and context lines
Date: Fri, 2 Sep 2011 20:45:34 +0200 [thread overview]
Message-ID: <1k6zins.7n7tsq12p4bczM%lists@haller-berlin.de> (raw)
In-Reply-To: <87ty8udd68.fsf@gmail.com>
Vijay Lakshminarayanan <laksvij@gmail.com> wrote:
> lists@haller-berlin.de (Stefan Haller) writes:
>
> > Is there a reason why the hard-coded default is 3 in the current code?
>
> 3 is the default context for GNU diff (and possibly other diff
> implementations also).
I think you misunderstood my question; I realize that 3 is a useful
default for "git show" or "git log -p" et al, for the reason you give.
My question was why 3 is the hard-coded value for calculating patch-ids.
For that case, 1 seems to make more sense to me.
--
Stefan Haller
Berlin, Germany
http://www.haller-berlin.de/
next prev parent reply other threads:[~2011-09-02 18:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 10:35 rev-list --cherry-pick and context lines Stefan Haller
2011-09-02 15:32 ` Michael J Gruber
2011-09-02 16:33 ` Stefan Haller
2011-09-02 18:14 ` Vijay Lakshminarayanan
2011-09-02 18:45 ` Stefan Haller [this message]
2011-09-02 19:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1k6zins.7n7tsq12p4bczM%lists@haller-berlin.de \
--to=lists@haller-berlin.de \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=laksvij@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).