From: lists@haller-berlin.de (Stefan Haller)
To: paulus@samba.org (Paul Mackerras)
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3] gitk: Synchronize highlighting in file view when scrolling diff
Date: Mon, 24 Sep 2012 07:51:56 +0200 [thread overview]
Message-ID: <1kqvbob.1e7rv3c1cyer9qM%lists@haller-berlin.de> (raw)
In-Reply-To: <20120923065825.GA15889@bloggs.ozlabs.ibm.com>
Paul Mackerras <paulus@samba.org> wrote:
> On Wed, Sep 19, 2012 at 08:17:27PM +0200, Stefan Haller wrote:
> > Here's one way how to address your concern. When pressing the search button
> > it will highlight the file that contains the current search hit; if you then
> > scroll from there though, the normal mechanism kicks in again and might
> > highlight the previous file. The same happens now if you select the last file
> > in the list, but it's diff is smaller than a screenful. In the previous
> > patch versions it would select a different file than you clicked on, which
> > is probably also confusing.
> >
> > Is this what you had in mind?
>
> Yes, it is, and I applied your patch. I wonder though if it might
> work better to highlight all the files that are visible?
Interesting idea. I tried it, but I don't like it much, it just looks
and feels so odd. I can send a patch if you're interested in trying it
yourself.
But personally, I really only need the synchronization feature in the
case where a file's diff is longer than fits on a screen; as long as a
file header is visible on the left side, it's prominent enough that I
don't need more guidance.
-Stefan
--
Stefan Haller
Berlin, Germany
http://www.haller-berlin.de/
next prev parent reply other threads:[~2012-09-24 5:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 5:57 [PATCH] gitk: Synchronize highlighting in file view when scrolling diff Stefan Haller
2012-09-18 18:23 ` Peter Oberndorfer
2012-09-19 9:57 ` [PATCH v2] " Stefan Haller
2012-09-18 23:46 ` [PATCH] " Paul Mackerras
2012-09-19 14:28 ` Marc Branchaud
2012-09-19 18:17 ` [PATCH v3] " Stefan Haller
2012-09-23 6:58 ` Paul Mackerras
2012-09-24 5:51 ` Stefan Haller [this message]
2012-10-26 22:03 ` [PATCH] gitk: Do not select file list entries during diff loading Peter Oberndorfer
2012-10-29 8:56 ` Stefan Haller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1kqvbob.1e7rv3c1cyer9qM%lists@haller-berlin.de \
--to=lists@haller-berlin.de \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).