From: Petr Baudis <pasky@ucw.cz>
To: Pavel Roskin <proski@gnu.org>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] gittrack.sh accepts invalid branch names
Date: Thu, 21 Apr 2005 01:21:10 +0200 [thread overview]
Message-ID: <20050420232110.GA12962@pasky.ji.cz> (raw)
In-Reply-To: <1114026510.15186.15.camel@dv>
Dear diary, on Wed, Apr 20, 2005 at 09:48:30PM CEST, I got a letter
where Pavel Roskin <proski@gnu.org> told me that...
> --- a/gittrack.sh
> +++ b/gittrack.sh
> @@ -35,7 +35,7 @@ die () {
> mkdir -p .git/heads
>
> if [ "$name" ]; then
> - grep -q $(echo -e "^$name\t" | sed 's/\./\\./g') .git/remotes || \
> + sed -ne "/^$name\t/p" .git/remotes | grep -q . || \
> [ -s ".git/heads/$name" ] || \
> die "unknown branch \"$name\""
This fixes the acceptance, but not the choice.
What does the grep -q . exactly do? Just sets error code based on
whether the sed output is non-empty? What about [] instead?
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor
next prev parent reply other threads:[~2005-04-20 23:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-20 19:48 [PATCH] gittrack.sh accepts invalid branch names Pavel Roskin
2005-04-20 23:21 ` Petr Baudis [this message]
2005-04-21 1:28 ` Pavel Roskin
2005-04-20 23:22 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050420232110.GA12962@pasky.ji.cz \
--to=pasky@ucw.cz \
--cc=git@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).