From: Klaus Robert Suetterlin <robert@mpe.mpg.de>
To: Mike Taht <mike.taht@timesys.com>
Cc: git@vger.kernel.org
Subject: HOWTO: PATCH: don't hardcode path-to-bash, use sys/limits.h
Date: Thu, 21 Apr 2005 12:23:26 +0200 [thread overview]
Message-ID: <20050421102326.GA22541@xdt04.mpe-garching.mpg.de> (raw)
In-Reply-To: <4267387A.6040602@timesys.com>
Hi,
I supply a patch that dehardcodes the path to bash (which is not /bin on all computers) and adds sys/limits.h to provide ULONG_MAX.
If this is not the right way to supply patches, or if this email misses some crucial point please tell me so, and supply explanation.
--
Robert Suetterlin (robert@mpe.mpg.de)
phone: (+49)89 / 30000-3546 fax: (+49)89 / 30000-3950
commit 5f6caff82b1f3b5931d92aaff99be6d8dbad10ca
tree d7ea8aeefbbc2ab63cb5acd41b647b1b5f11fb83
parent cd1c034369b73da7503da365fa556aab27004814
author Klaus Robert Suetterlin <krs@xdt04.mpe-garching.mpg.de> 1114078431 +0200
committer Klaus Robert Suetterlin <krs@xdt04.mpe-garching.mpg.de> 1114078431 +0200
Don't hardcode the path-to-bash please.
Index: commit.c
===================================================================
--- c0260bfb82da04aeff4e598ced5295d6ae2e262d/commit.c (mode:100644 sha1:eda45d7e15358ed6f2cd0502de2a08987307fc98)
+++ d7ea8aeefbbc2ab63cb5acd41b647b1b5f11fb83/commit.c (mode:100644 sha1:cfe9a8ddf6ee2702e3923cb22240f9f9ed1bd04c)
@@ -1,3 +1,4 @@
+#include <sys/limits.h>
#include "commit.h"
#include "cache.h"
#include <string.h>
Index: gitdiff-do
===================================================================
--- c0260bfb82da04aeff4e598ced5295d6ae2e262d/gitdiff-do (mode:100755 sha1:afed4e40b259a61b0f12979ba7326f26743bc553)
+++ d7ea8aeefbbc2ab63cb5acd41b647b1b5f11fb83/gitdiff-do (mode:100755 sha1:218dfabeb4a5dcbd2cf58bd6f672f385690ec397)
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
#
# Make a diff between two GIT trees.
# Copyright (c) Petr Baudis, 2005
Index: gitlog.sh
===================================================================
--- c0260bfb82da04aeff4e598ced5295d6ae2e262d/gitlog.sh (mode:100755 sha1:a496a864f9586e47a4d7bd3ae0af0b3e07b7deb8)
+++ d7ea8aeefbbc2ab63cb5acd41b647b1b5f11fb83/gitlog.sh (mode:100755 sha1:7b3aa8a89bc64273c648920ccd1686859754803e)
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
#
# Make a log of changes in a GIT branch.
#
next prev parent reply other threads:[~2005-04-21 10:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-21 5:06 Performance of various compressors Mike Taht
2005-04-21 5:14 ` Mike Taht
2005-04-21 5:22 ` [PATCH] experimental - " Mike Taht
2005-04-21 10:23 ` Klaus Robert Suetterlin [this message]
2005-04-21 14:31 ` HOWTO: PATCH: don't hardcode path-to-bash, use sys/limits.h Alecs King
2005-04-21 19:42 ` [PATCH] #!/bin/sh --> #!/usr/bin/env bash Alecs King
2005-04-22 7:37 ` H. Peter Anvin
2005-04-23 2:34 ` David A. Wheeler
2005-04-23 6:16 ` H. Peter Anvin
2005-04-22 20:38 ` Performance of various compressors Aaron Lehmann
2005-04-25 12:17 ` git I/O performance (was: Performance of various compressors) Klaus Robert Suetterlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050421102326.GA22541@xdt04.mpe-garching.mpg.de \
--to=robert@mpe.mpg.de \
--cc=git@vger.kernel.org \
--cc=mike.taht@timesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).