git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] cg-mkpatch: Show diffstat before the patch
@ 2005-04-26 22:58 Jonas Fonseca
  2005-04-27 23:55 ` Petr Baudis
  2005-04-28  0:07 ` YOSHIFUJI Hideaki / 吉藤英明
  0 siblings, 2 replies; 4+ messages in thread
From: Jonas Fonseca @ 2005-04-26 22:58 UTC (permalink / raw)
  To: pasky; +Cc: git

Show diffstat before the patch.

Signed-off-by: Jonas Fonseca <fonseca@diku.dk>

---
commit a738ed98e4557877f8bcd3b992aa55579b22b9d1
tree 2447d3a399200c8f736344822969f88f675612dd
parent ed095b1a965517f1674b812a9978c60eb907e192
author Jonas Fonseca <fonseca@diku.dk> 1114554627 +0200
committer Jonas Fonseca <fonseca@diku.dk> 1114554627 +0200

 cg-mkpatch |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletion(-)

Index: cg-mkpatch
===================================================================
--- 6159f313b10f0cfcdfedd63d6fb044029fe46aaa/cg-mkpatch  (mode:100755 sha1:5ba423cbbb3e5f72cd7fb74f2873d49b60557f12)
+++ 2447d3a399200c8f736344822969f88f675612dd/cg-mkpatch  (mode:100755 sha1:25c67a29296730daeac00e43fd4c18cf914a1c87)
@@ -23,7 +23,10 @@
 		echo $line >>$header
 	done
 	echo
-	cg-diff -p -r $id
+	cg-diff -p -r $id > $header
+	cat $header | diffstat
+	echo
+	cat $header
 	rm $header
 }
 


-- 
Jonas Fonseca

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] cg-mkpatch: Show diffstat before the patch
  2005-04-26 22:58 [PATCH] cg-mkpatch: Show diffstat before the patch Jonas Fonseca
@ 2005-04-27 23:55 ` Petr Baudis
  2005-04-28  0:07 ` YOSHIFUJI Hideaki / 吉藤英明
  1 sibling, 0 replies; 4+ messages in thread
From: Petr Baudis @ 2005-04-27 23:55 UTC (permalink / raw)
  To: git

Dear diary, on Wed, Apr 27, 2005 at 12:58:55AM CEST, I got a letter
where Jonas Fonseca <fonseca@diku.dk> told me that...
> Show diffstat before the patch.
> 
> Signed-off-by: Jonas Fonseca <fonseca@diku.dk>

I think you should first check by which(1) or something whether you have
diffstat. Piling up dependencies like this is pretty annoying.

Thanks,

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] cg-mkpatch: Show diffstat before the patch
  2005-04-26 22:58 [PATCH] cg-mkpatch: Show diffstat before the patch Jonas Fonseca
  2005-04-27 23:55 ` Petr Baudis
@ 2005-04-28  0:07 ` YOSHIFUJI Hideaki / 吉藤英明
  2005-04-28  0:16   ` Petr Baudis
  1 sibling, 1 reply; 4+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2005-04-28  0:07 UTC (permalink / raw)
  To: fonseca; +Cc: pasky, git

In article <20050426225855.GA28560@diku.dk> (at Wed, 27 Apr 2005 00:58:55 +0200), Jonas Fonseca <fonseca@diku.dk> says:

> Show diffstat before the patch.

We do not always need to generate diffstat.
Please add -s option or something to prepend diffstat.
Thanks.

--yoshfuji

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] cg-mkpatch: Show diffstat before the patch
  2005-04-28  0:07 ` YOSHIFUJI Hideaki / 吉藤英明
@ 2005-04-28  0:16   ` Petr Baudis
  0 siblings, 0 replies; 4+ messages in thread
From: Petr Baudis @ 2005-04-28  0:16 UTC (permalink / raw)
  To: YOSHIFUJI Hideaki / ?$B5HF#1QL@; +Cc: fonseca, git

Dear diary, on Thu, Apr 28, 2005 at 02:07:02AM CEST, I got a letter
where "YOSHIFUJI Hideaki / ?$B5HF#1QL@" <yoshfuji@linux-ipv6.org> told me that...
> In article <20050426225855.GA28560@diku.dk> (at Wed, 27 Apr 2005 00:58:55 +0200), Jonas Fonseca <fonseca@diku.dk> says:
> 
> > Show diffstat before the patch.
> 
> We do not always need to generate diffstat.
> Please add -s option or something to prepend diffstat.
> Thanks.

Actually, I've been thinking about something like -s, but as in "short",
which would skip this --- part altogether.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2005-04-28  0:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-26 22:58 [PATCH] cg-mkpatch: Show diffstat before the patch Jonas Fonseca
2005-04-27 23:55 ` Petr Baudis
2005-04-28  0:07 ` YOSHIFUJI Hideaki / 吉藤英明
2005-04-28  0:16   ` Petr Baudis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).