From: Thomas Glanzmann <sithglan@stud.uni-erlangen.de>
To: GIT <git@vger.kernel.org>
Subject: Re: update-cache ./test.c
Date: Sun, 1 May 2005 11:04:37 +0200 [thread overview]
Message-ID: <20050501090437.GK26663@cip.informatik.uni-erlangen.de> (raw)
In-Reply-To: <20050501085922.GC30692@xi.wantstofly.org>
Hello,
> --- git/update-cache.c.orig 2005-05-01 10:56:17.859313581 +0200
> +++ git/update-cache.c 2005-05-01 10:57:31.634897508 +0200
> @@ -328,6 +328,7 @@
> for (i = 1 ; i < argc; i++) {
> char *path = argv[i];
> + char *_path;
I think there is no need to introduce an extra variable. Just increase
path by two. I knew that it is easy to fix in the code, but I think the
'logic' should go into the frontend not in the backend. But this one is
really easy to fix. Maybe regenerate a patch and sign it off, maybe it
will be included.
Greetings,
Thomas
next prev parent reply other threads:[~2005-05-01 8:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-01 8:41 update-cache ./test.c Lennert Buytenhek
2005-05-01 8:47 ` Thomas Glanzmann
2005-05-01 8:54 ` Lennert Buytenhek
2005-05-01 8:59 ` Lennert Buytenhek
2005-05-01 9:04 ` Thomas Glanzmann [this message]
2005-05-01 10:31 ` Junio C Hamano
2005-05-01 9:43 ` David Greaves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050501090437.GK26663@cip.informatik.uni-erlangen.de \
--to=sithglan@stud.uni-erlangen.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).