git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* PATCH: diff-cache.c:51: `return' with a value, in function returning void
@ 2005-05-03 19:56 Alex Riesen
  2005-05-03 21:33 ` Junio C Hamano
  0 siblings, 1 reply; 3+ messages in thread
From: Alex Riesen @ 2005-05-03 19:56 UTC (permalink / raw)
  To: Petr Baudis; +Cc: git

gcc -g -O2 -Wall  '-DSHA1_HEADER=<openssl/sha.h>' -o git-diff-cache diff-cache.c libgit.a -lz -lssl
diff-cache.c: In function `show_new_file':
diff-cache.c:51: warning: `return' with a value, in function returning void


--- cogito/diff-cache.c	2005-05-03 21:50:42.000000000 +0200
+++ cogito/diff-cache.c	2005-05-03 21:52:00.000000000 +0200
@@ -48,7 +48,6 @@ static void show_new_file(struct cache_e
 		return;
 
 	show_file("+", new, sha1, mode);
-	return 0;
 }
 
 static int show_modified(struct cache_entry *old, struct cache_entry *new)


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: PATCH: diff-cache.c:51: `return' with a value, in function returning void
  2005-05-03 19:56 PATCH: diff-cache.c:51: `return' with a value, in function returning void Alex Riesen
@ 2005-05-03 21:33 ` Junio C Hamano
  2005-05-03 21:44   ` Alex Riesen
  0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2005-05-03 21:33 UTC (permalink / raw)
  To: Alex Riesen; +Cc: Petr Baudis, git

>>>>> "AR" == Alex Riesen <fork0@users.sourceforge.net> writes:

AR> gcc -g -O2 -Wall  '-DSHA1_HEADER=<openssl/sha.h>' -o git-diff-cache diff-cache.c libgit.a -lz -lssl
AR> diff-cache.c: In function `show_new_file':
AR> diff-cache.c:51: warning: `return' with a value, in function returning void

This one was fixed in the Linus tree long time ago.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: PATCH: diff-cache.c:51: `return' with a value, in function returning void
  2005-05-03 21:33 ` Junio C Hamano
@ 2005-05-03 21:44   ` Alex Riesen
  0 siblings, 0 replies; 3+ messages in thread
From: Alex Riesen @ 2005-05-03 21:44 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Petr Baudis, git

Junio C Hamano, Tue, May 03, 2005 23:33:22 +0200:
> >>>>> "AR" == Alex Riesen <fork0@users.sourceforge.net> writes:
> 
> AR> gcc -g -O2 -Wall  '-DSHA1_HEADER=<openssl/sha.h>' -o git-diff-cache diff-cache.c libgit.a -lz -lssl
> AR> diff-cache.c: In function `show_new_file':
> AR> diff-cache.c:51: warning: `return' with a value, in function returning void
> 
> This one was fixed in the Linus tree long time ago.
> 

Oh, sorry: it was cogito today.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-05-03 21:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-03 19:56 PATCH: diff-cache.c:51: `return' with a value, in function returning void Alex Riesen
2005-05-03 21:33 ` Junio C Hamano
2005-05-03 21:44   ` Alex Riesen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).