From: Greg KH <greg@kroah.com>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Linus Torvalds <torvalds@osdl.org>, git@vger.kernel.org
Subject: Re: [PATCH] fix compare symlink against readlink not data
Date: Fri, 6 May 2005 09:03:59 -0700 [thread overview]
Message-ID: <20050506160359.GB6904@kroah.com> (raw)
In-Reply-To: <20050506134501.GA11430@vrfy.org>
On Fri, May 06, 2005 at 03:45:01PM +0200, Kay Sievers wrote:
> Fix update-cache to compare the blob of a symlink against the link-target
> and not the file it points to. Also ignore all permissions applied to
> links.
> Thanks to Greg for recognizing this while he added our list of symlinks
> back to the udev repository.
Hm, even with this patch applied (it's in Linus's tree right now), I
still get the following with a clean checked out udev tree:
$ cg-diff
Index: test/sys/block/cciss!c0d0/device
===================================================================
Index: test/sys/block/rd!c0d0/device
===================================================================
Index: test/sys/block/sda/device
===================================================================
Index: test/sys/bus/pci/devices/0000:00:09.0
===================================================================
Index: test/sys/bus/pci/devices/0000:00:1e.0
===================================================================
Index: test/sys/bus/pci/devices/0000:02:05.0
===================================================================
Index: test/sys/bus/pci/drivers/aic7xxx/0000:02:05.0
===================================================================
Index: test/sys/bus/scsi/devices/0:0:0:0
===================================================================
Index: test/sys/bus/scsi/drivers/sd/0:0:0:0
===================================================================
Index: test/sys/bus/usb-serial/devices/ttyUSB0
===================================================================
Index: test/sys/bus/usb-serial/drivers/PL-2303/ttyUSB0
===================================================================
Index: test/sys/bus/usb/devices/3-0:1.0
===================================================================
Index: test/sys/bus/usb/devices/3-1
===================================================================
Index: test/sys/bus/usb/devices/3-1:1.0
===================================================================
Index: test/sys/bus/usb/devices/usb3
===================================================================
Index: test/sys/bus/usb/drivers/hub/3-0:1.0
===================================================================
Index: test/sys/bus/usb/drivers/pl2303/3-1:1.0
===================================================================
Index: test/sys/bus/usb/drivers/usb/3-1
===================================================================
Index: test/sys/bus/usb/drivers/usb/usb3
===================================================================
Index: test/sys/class/tty/ttyUSB0/device
===================================================================
Index: test/sys/devices/pci0000:00/0000:00:09.0/usb3/3-1/ttyUSB0/driver
===================================================================
Any idea?
thanks,
greg k-h
next prev parent reply other threads:[~2005-05-06 15:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-06 13:45 [PATCH] fix compare symlink against readlink not data Kay Sievers
2005-05-06 16:03 ` Greg KH [this message]
2005-05-06 16:23 ` Kay Sievers
2005-05-06 16:36 ` Greg KH
2005-05-06 16:59 ` Kay Sievers
2005-05-06 17:11 ` Linus Torvalds
2005-05-06 17:19 ` Greg KH
2005-05-06 16:26 ` Junio C Hamano
2005-05-06 16:37 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050506160359.GB6904@kroah.com \
--to=greg@kroah.com \
--cc=git@vger.kernel.org \
--cc=kay.sievers@vrfy.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).