git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Baudis <pasky@ucw.cz>
To: David Greaves <david@dgreaves.com>
Cc: GIT Mailing Lists <git@vger.kernel.org>
Subject: Re: [PATCH] Ignore file filter
Date: Sat, 14 May 2005 01:12:29 +0200	[thread overview]
Message-ID: <20050513231229.GI32232@pasky.ji.cz> (raw)
In-Reply-To: <4283CAF8.3050304@dgreaves.com>

Dear diary, on Thu, May 12, 2005 at 11:30:32PM CEST, I got a letter
where David Greaves <david@dgreaves.com> told me that...
> # This doesn't allow the -h which is the [ arg for symlinks...

But so is -L. And I'd just use -l...

> #. ${COGITO_LIB}cg-Xlib
> _git=${GIT_DIR:-.git}

...but it makes no sense anyway I think to reinclude this stuff from a
cg-Xfile you are including from other scripts anyway.

> 	    if [[ $file =~ $patt ]]; then

I'm sorry but this is really nothing my bash-2.05.0(1)-release supports.
We're already bash-only, but further reducing that to bash3 really won't
work. I *might* get convinced to add some bash2+-only feature, but only
if you'll be really good at explaining that it makes sense.

Besides, I'd prefer just the shell globs in the ignore file, as it is
done in the rest of the world, and in all the real-world scenarios I've
seen, the globs were powerful enough.

Also, how does this interact with git-ls-files --exclude and
.git/exclude? We would have two ignoring mechanisms...

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor

  parent reply	other threads:[~2005-05-13 23:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-12 21:30 [PATCH] Ignore file filter David Greaves
     [not found] ` <7v64xodshs.fsf@assigned-by-dhcp.cox.net>
2005-05-13  8:50   ` David Greaves
2005-05-13 23:12 ` Petr Baudis [this message]
2005-05-14  8:28   ` David Greaves
2005-05-14  9:01     ` Junio C Hamano
2005-05-14 14:24       ` Petr Baudis
2005-05-14 15:13         ` David Greaves
2005-05-14 15:30           ` [RFD] Ignore rules Petr Baudis
2005-05-14 17:51             ` David Greaves
2005-05-14 18:12             ` Junio C Hamano
2005-05-15  1:11               ` Jon Seymour
2005-05-15  6:05                 ` Junio C Hamano
2005-05-15  6:52                   ` Junio C Hamano
2005-05-15 20:27                   ` [RFD] git-run-with-user-path Junio C Hamano
2005-05-16  9:35                 ` [RFD] Ignore rules Matthias Urlichs
2005-05-16 16:05                   ` David Greaves
2005-05-14 12:21     ` [PATCH] Ignore file filter Petr Baudis
2005-05-14 14:28       ` David Greaves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050513231229.GI32232@pasky.ji.cz \
    --to=pasky@ucw.cz \
    --cc=david@dgreaves.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).