From: Petr Baudis <pasky@ucw.cz>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH 2/4] Tweak diff output further to make it a bit less distracting.
Date: Tue, 17 May 2005 00:05:59 +0200 [thread overview]
Message-ID: <20050516220559.GC8609@pasky.ji.cz> (raw)
In-Reply-To: <7vvf5kqj9l.fsf@assigned-by-dhcp.cox.net>
Dear diary, on Sun, May 15, 2005 at 11:19:50PM CEST, I got a letter
where Junio C Hamano <junkio@cox.net> told me that...
> Adds an newline between each diff. Also change "#mode : "
> string, which was misleading in that we are not showing just
> mode when we talk about a file changing into a symlink.
>
> Signed-off-by: Junio C Hamano <junkio@cox.net>
So, I've been looking at the output, and I have to admit that I'm still
not too happy with it (I know I'm horrible). It turned out to be rather
confusing, since there are normally no blank lines in the middle of the
diffs, so it looked as the blank lines were actually part of the diffed
files.
What about just throwing away the newlines and just passing '@.'?
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor
next prev parent reply other threads:[~2005-05-16 22:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-15 21:19 [PATCH 2/4] Tweak diff output further to make it a bit less distracting Junio C Hamano
2005-05-16 22:05 ` Petr Baudis [this message]
2005-05-16 22:51 ` Junio C Hamano
2005-05-16 23:28 ` Linus Torvalds
2005-05-16 23:44 ` Junio C Hamano
2005-05-18 13:40 ` Matthias Urlichs
2005-05-18 15:20 ` Linus Torvalds
2005-05-18 16:07 ` Matthias Urlichs
2005-05-18 16:10 ` [PATCH] Fix diff output take #4 Junio C Hamano
2005-05-17 0:10 ` [PATCH 2/4] Tweak diff output further to make it a bit less distracting Daniel Barkalow
2005-05-17 21:11 ` Petr Baudis
2005-05-17 21:19 ` Junio C Hamano
2005-05-17 0:11 ` [PATCH] Fix diff output take #3 Junio C Hamano
2005-05-17 7:01 ` [PATCH 2/4] Tweak diff output further to make it a bit less distracting Petr Baudis
2005-05-17 15:20 ` Linus Torvalds
2005-05-17 19:08 ` Junio C Hamano
2005-05-17 19:32 ` Linus Torvalds
2005-05-17 22:25 ` Junio C Hamano
2005-05-17 23:32 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050516220559.GC8609@pasky.ji.cz \
--to=pasky@ucw.cz \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).