From: Herbert Xu <herbert@gondor.apana.org.au>
To: Junio C Hamano <junkio@cox.net>
Cc: Daniel Barkalow <barkalow@iabervon.org>,
torvalds@osdl.org, git@vger.kernel.org
Subject: Re: [PATCH] Fix use of wc in t0000-basic
Date: Sat, 21 May 2005 21:01:29 +1000 [thread overview]
Message-ID: <20050521110129.GA7924@gondor.apana.org.au> (raw)
In-Reply-To: <7vhdgwj1ed.fsf@assigned-by-dhcp.cox.net>
On Sat, May 21, 2005 at 03:53:30AM -0700, Junio C Hamano wrote:
> >>>>> "HX" == Herbert Xu <herbert@gondor.apana.org.au> writes:
>
> HX> It's also better to use -eq instead of = since you are comparing
> HX> numbers, not strings. If you do that you can keep the double
> HX> quotes since the spaces will be removed automatically.
>
> I remember being burned by busybox "test" which did not ignore
> spaces. I do not know if the latest one is fixed, though.
Are you sure that it didn't ignore the leading spaces with -eq?
The code in question just calls strtol.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2005-05-21 11:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-21 0:49 [PATCH] Fix use of wc in t0000-basic Daniel Barkalow
2005-05-21 1:08 ` Sean
2005-05-21 1:10 ` Daniel Barkalow
2005-05-21 1:13 ` Sean
2005-05-21 1:16 ` Daniel Barkalow
2005-05-21 1:43 ` Junio C Hamano
2005-05-21 10:37 ` Herbert Xu
2005-05-21 10:53 ` Junio C Hamano
2005-05-21 11:01 ` Herbert Xu [this message]
2005-05-21 17:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050521110129.GA7924@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).