From: Thomas Glanzmann <sithglan@stud.uni-erlangen.de>
To: GIT <git@vger.kernel.org>
Subject: Re: Alternate Patch: [PATCH] Don't include device number in cache invalidation when running on NFS
Date: Mon, 23 May 2005 00:07:34 +0200 [thread overview]
Message-ID: <20050522220734.GF23388@cip.informatik.uni-erlangen.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0505221451590.2307@ppc970.osdl.org>
Hello,
> This is _really_ Linux-specific afaik. Which is ok for git, but at the
> same time it really makes me go "Ewww". It's testing that the major number
> is 0, and it would be a lot more cleaner to use
> if (!major(st.st_dev))
> but even that is very Linux-specific.
I see.
> I'll have to think about it. Maybe I should just remove the st_dev check.
> I guess inode/size/mtime/ctime should be plenty safe enough in practice.
I think so. At least I kick this one out because it is just getting on
my nerves. :-)
Thomas
prev parent reply other threads:[~2005-05-22 22:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-22 12:28 running git-update-cache --refresh on different machines on a NFS share always ends up in a lot of io/cpu/time waste Thomas Glanzmann
2005-05-22 19:09 ` Linus Torvalds
2005-05-22 19:27 ` Thomas Glanzmann
2005-05-22 20:43 ` Linus Torvalds
2005-05-22 21:23 ` [PATCH] Don't include devicenumber into INODE_CHANGED test [WAS: Re: running git-update-cache --refresh on different machines on a NFS share always ends up in a lot of io/cpu/time waste] Thomas Glanzmann
2005-05-22 21:41 ` Alternate Patch: [PATCH] Don't include device number in cache invalidation when running on NFS Thomas Glanzmann
2005-05-22 21:58 ` Linus Torvalds
2005-05-22 22:07 ` Thomas Glanzmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050522220734.GF23388@cip.informatik.uni-erlangen.de \
--to=sithglan@stud.uni-erlangen.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).