git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [COGITO PATCH] fix "cg-Xnormid: command not found" error
@ 2005-05-29  3:15 YOSHIFUJI Hideaki / 吉藤英明
  2005-05-29  9:57 ` Marcel Holtmann
  0 siblings, 1 reply; 3+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2005-05-29  3:15 UTC (permalink / raw)
  To: git

Call cg-Xnormid with ${COGITO_LIB} to fix "cg-Xnormid: command not found"
error.

Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>

Index: commit-id
===================================================================
--- c8e987e5e4608c1144293cd3f852210d70b572cb/commit-id  (mode:100755)
+++ uncommitted/commit-id  (mode:100755)
@@ -8,7 +8,7 @@
 . ${COGITO_LIB}cg-Xlib
 
 id="$1"
-normid=$(cg-Xnormid "$id") || exit 1
+normid=$(${COGITO_LIB}cg-Xnormid "$id") || exit 1
 
 if [ "$(git-cat-file -t "$normid")" != "commit" ]; then
 	echo "Invalid commit id: $id" >&2
Index: tree-id
===================================================================
--- c8e987e5e4608c1144293cd3f852210d70b572cb/tree-id  (mode:100755)
+++ uncommitted/tree-id  (mode:100755)
@@ -6,7 +6,7 @@
 # Takes ID of the appropriate commit, defaults to HEAD.
 
 id="$1"
-normid=$(cg-Xnormid "$id") || exit 1
+normid=$(${COGITO_LIB}cg-Xnormid "$id") || exit 1
 type=$(git-cat-file -t "$normid")
 
 if [ "$type" = "commit" ]; then


-- 
YOSHIFUJI Hideaki @ USAGI Project  <yoshfuji@linux-ipv6.org>
GPG-FP  : 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [COGITO PATCH] fix "cg-Xnormid: command not found" error
  2005-05-29  3:15 [COGITO PATCH] fix "cg-Xnormid: command not found" error YOSHIFUJI Hideaki / 吉藤英明
@ 2005-05-29  9:57 ` Marcel Holtmann
  2005-05-29 12:06   ` Petr Baudis
  0 siblings, 1 reply; 3+ messages in thread
From: Marcel Holtmann @ 2005-05-29  9:57 UTC (permalink / raw)
  To: YOSHIFUJI Hideaki / 吉藤英明; +Cc: git

Hi,

> Call cg-Xnormid with ${COGITO_LIB} to fix "cg-Xnormid: command not found"
> error.

I made the same patch, but when I used cg-diff to create the patch, I
got two extra annoying lines at the top.

commit-id: needs update
tree-id: needs update
Index: commit-id
===================================================================
--- c8e987e5e4608c1144293cd3f852210d70b572cb/commit-id  (mode:100755)
+++ uncommitted/commit-id  (mode:100755)

I think the "needs update" lines came from "git-update-cache --refresh"
and we don't really want them there. Should we simply direct the output
to /dev/null or what?

Regards

Marcel



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [COGITO PATCH] fix "cg-Xnormid: command not found" error
  2005-05-29  9:57 ` Marcel Holtmann
@ 2005-05-29 12:06   ` Petr Baudis
  0 siblings, 0 replies; 3+ messages in thread
From: Petr Baudis @ 2005-05-29 12:06 UTC (permalink / raw)
  To: Marcel Holtmann; +Cc: YOSHIFUJI Hideaki / ????????????, git

Dear diary, on Sun, May 29, 2005 at 11:57:57AM CEST, I got a letter
where Marcel Holtmann <marcel@holtmann.org> told me that...
> I made the same patch, but when I used cg-diff to create the patch, I
> got two extra annoying lines at the top.
> 
> commit-id: needs update
> tree-id: needs update
> Index: commit-id
> ===================================================================
> --- c8e987e5e4608c1144293cd3f852210d70b572cb/commit-id  (mode:100755)
> +++ uncommitted/commit-id  (mode:100755)
> 
> I think the "needs update" lines came from "git-update-cache --refresh"
> and we don't really want them there. Should we simply direct the output
> to /dev/null or what?

Oh yes, this is one of the small things I've long meant to fix but never
really got to it. Thanks for reminding me, fixed now. :-)

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-05-29 12:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-29  3:15 [COGITO PATCH] fix "cg-Xnormid: command not found" error YOSHIFUJI Hideaki / 吉藤英明
2005-05-29  9:57 ` Marcel Holtmann
2005-05-29 12:06   ` Petr Baudis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).