From: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
To: Linus Torvalds <torvalds@osdl.org>
Cc: git@vger.kernel.org
Subject: [PATCH] git-tar-tree: do only basic tests in t/t5000-git-tar-tree.sh
Date: Fri, 3 Jun 2005 18:21:23 +0200 [thread overview]
Message-ID: <20050603162123.GA11107@lsrfire.ath.cx> (raw)
git-tar-tree: remove tests of long path handling out of t5000-tar-tree.sh
and make test script cope with tar programs displaying file modification
date as hh:mm (newer variants show it as hh:mm:ss).
This makes the test cover only basic functionality that is expected to
be handled even by older tar programs. Tests for long filenames (which
require pax extended headers) can be added separately.
I ran this test successfully with GNU tar 1.13, 1.14 and 1.15.1.
Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
--- a/t/t5000-tar-tree.sh
+++ b/t/t5000-tar-tree.sh
@@ -5,17 +5,13 @@
test_description='git-tar-tree and git-get-tar-commit-id test
-This test covers the topics of long paths, file contents, commit date
-handling and commit id embedding:
-
- Paths longer than 100 characters require the use of a pax extended
- header to store them. The test creates files with pathes both longer
- and shorter than 100 chars, and also checks symlinks with long and
- short pathes both as their own name and as target path.
+This test covers the topics of file contents, commit date handling and
+commit id embedding:
The contents of the repository is compared to the extracted tar
archive. The repository contains simple text files, symlinks and a
- binary file (/bin/sh).
+ binary file (/bin/sh). Only pathes shorter than 99 characters are
+ used.
git-tar-tree applies the commit date to every file in the archive it
creates. The test sets the commit date to a specific value and checks
@@ -33,20 +29,10 @@
test_expect_success \
'populate workdir' \
'mkdir a b c &&
- p48=1.......10........20........30........40......48 &&
- p50=1.......10........20........30........40........50 &&
- p98=${p48}${p50} &&
echo simple textfile >a/a &&
- echo 100 chars in path >a/${p98} &&
- echo 101 chars in path >a/${p98}x &&
- echo 102 chars in path >a/${p98}xx &&
- echo 103 chars in path >a/${p98}xxx &&
mkdir a/bin &&
- cp /bin/sh a/bin/sh &&
+ cp /bin/sh a/bin &&
ln -s a a/l1 &&
- ln -s ${p98}xx a/l100 &&
- ln -s ${p98}xxx a/l101 &&
- ln -s ${p98}xxx a/l${p98} &&
(cd a && find .) | sort >a.lst'
test_expect_success \
@@ -64,7 +50,8 @@
test_expect_success \
'validate file modification time' \
- 'tar tvf b.tar a/a | awk \{print\ \$4,\$5\} >b.mtime &&
+ 'tar tvf b.tar a/a |
+ awk \{print\ \$4,\ length\(\$5\)\<7\ ?\ \$5\":00\"\ :\ \$5\} >b.mtime &&
echo "2005-05-27 22:00:00" >expected.mtime &&
diff expected.mtime b.mtime'
reply other threads:[~2005-06-03 16:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050603162123.GA11107@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).