From: Chris Wright <chrisw@osdl.org>
To: Chris Wright <chrisw@osdl.org>
Cc: Dan Holmsand <holmsand@gmail.com>,
git@vger.kernel.org,
Konstantin Antselovich <konstantin@antselovich.com>,
Petr Baudis <pasky@ucw.cz>
Subject: Re: [ANNOUNCE] Cogito-0.11.3
Date: Thu, 9 Jun 2005 14:06:41 -0700 [thread overview]
Message-ID: <20050609210641.GK5324@shell0.pdx.osdl.net> (raw)
In-Reply-To: <20050609205503.GJ5324@shell0.pdx.osdl.net>
* Chris Wright (chrisw@osdl.org) wrote:
> * Dan Holmsand (holmsand@gmail.com) wrote:
> > Konstantin Antselovich wrote:
> > >I have updated to Cogito-0.11.3, it compiles and runs
> > >but make test returns multiple error messages (see below)
> >
> > There's a typo in rev-list.c. This fixes the tests for me:
>
> This patch is white space damaged. I fixed it, and added it to the
> cogito-0.11.3 rpm. Below is the refreshed patch.
Looks like showdate() is having some minor trouble. A simple cg-log
gave me errors indicating the tz is being interpreted as octal.
There's probably a better way, but bruteforce works ;-) This patch is
in the RPM packages which are now uploading.
thanks,
-chris
--
Strip leading zero from timezone to keep it from being interpreted as
octal causing error such as:
/usr/lib/cogito/cg-Xlib: line 69: 0800: value too great for base (error token is "0800")
Signed-off-by: Chris Wright <chrisw@osdl.org>
--- a/cg-Xlib
+++ b/cg-Xlib
@@ -65,7 +65,9 @@ showdate () {
[ "$format" ] || format=-R
sec=${date[0]}; tz=${date[1]}
if [ "$has_gnudate" ]; then
- dtz=${tz/+/}
+ dtz=${tz/-0/-}
+ dtz=${dtz/+/}
+ dtz=${dtz/#0/}
lsec=$(($dtz / 100 * 3600 + $dtz % 100 * 60 + $sec))
pdate="$(date -ud "1970-01-01 UTC + $lsec sec" "$format" 2>/dev/null)"
else
next prev parent reply other threads:[~2005-06-09 21:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-09 21:40 [COGITO PATCH] value too great for base (error token is "-0800") Pavel Roskin
2005-06-09 11:19 ` [PATCH 3/6] Make showdate use "Linus format" Dan Holmsand
2005-06-09 9:19 ` [ANNOUNCE] Cogito-0.11.3 Petr Baudis
2005-06-09 10:10 ` Konstantin Antselovich
2005-06-09 13:07 ` Dan Holmsand
2005-06-09 20:55 ` Chris Wright
2005-06-09 21:06 ` Chris Wright [this message]
2005-06-09 3:40 ` [PATCH] Fix cogito handling of timezones Frank Sorenson
2005-06-09 8:29 ` Petr Baudis
2005-06-09 14:20 ` Frank Sorenson
2005-06-10 22:19 ` Petr Baudis
2005-06-10 22:59 ` [PATCH 3/6] Make showdate use "Linus format" Petr Baudis
2005-06-11 8:28 ` Dan Holmsand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050609210641.GK5324@shell0.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=git@vger.kernel.org \
--cc=holmsand@gmail.com \
--cc=konstantin@antselovich.com \
--cc=pasky@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).